Phase2-hgx308 Add the new conversion code of Flat file to XML

[bsunanda]

PR description:

Add the new conversion code of Flat file to XML

PR validation:

Test the the new conversion code on a recent flat file for silicon. Also used the standard matrix for testing

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37547/29275

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37547/29275/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37547/29275/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37547/29276

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0bc97/23870/summary.html
COMMIT: dd4ead2
CMSSW: CMSSW_12_4_X_2022-04-12-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37547/23870/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Leaving Package RecoEcal/EgammaClusterProducers
>> Package RecoEcal/EgammaClusterProducers built
>> Subsystem RecoEcal built
>> Entering Package src/BigProducts/Simulation
>> Building  big plugin tmp/slc7_amd64_gcc10/src/BigProducts/Simulation/pluginSimulation.so
c++: error: objs/slc7_amd64_gcc10/ValidationHGCalValidationAuto.obj: No such file or directory
gmake: *** [tmp/slc7_amd64_gcc10/src/BigProducts/Simulation/pluginSimulation.so] Error 1
>> Leaving Package src/BigProducts/Simulation
>> Package src/BigProducts/Simulation built
>> Leaving Package src/BigProducts/Simulation
>> Package src/BigProducts/Simulation built


[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0bc97/23972/summary.html
COMMIT: c571482
CMSSW: CMSSW_12_4_X_2022-04-16-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37547/23972/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3591161
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3591119
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cvuosalo]

+1

[bsunanda]

@srimanob Can you sign it again. The latest change was to correct the spelling of cassette

[srimanob]

+Upgrade

Re-sign. The last commit was to handle typo.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1