HCalDQM: Fix for issue #37486 collection tag correction

[lwang046]

PR description:

A fix for issue #37486 by replacing hbhereco with hbheprereco for relevant tasks.

PR validation:

Tested okay with GPU workflows 10824.523, 10824.583 and 10824.587.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37537/29255

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @lwang046 for master.

It involves the following packages:

• DQM/HcalTasks (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@bsunanda, @abdoulline, @DryRun this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75958c/23890/summary.html
COMMIT: 5e62cc3
CMSSW: CMSSW_12_4_X_2022-04-13-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37537/23890/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 138.4

----- Begin Fatal Exception 13-Apr-2022 20:59:14 UTC-----------------------
An exception of category 'HCALDQM' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module RecHitTask/'recHitTask'
Exception Message:
RecHitTask::Collection HBHERecHitCollection not available hbheprereco 
----- End Fatal Exception -------------------------------------------------

• 138.5

----- Begin Fatal Exception 13-Apr-2022 20:59:23 UTC-----------------------
An exception of category 'HCALDQM' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmoffline_1_step'
   [2] Calling method for module RecHitTask/'recHitTask'
Exception Message:
RecHitTask::Collection HBHERecHitCollection not available hbheprereco 
----- End Fatal Exception -------------------------------------------------

• 312.0

----- Begin Fatal Exception 13-Apr-2022 21:03:04 UTC-----------------------
An exception of category 'HCALDQM' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module RecHitTask/'recHitTask'
Exception Message:
RecHitTask::Collection HBHERecHitCollection not available hbheprereco 
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 11634.914
• 39496.0
• 11634.7
• 11634.0
• 39500.0
• 12434.0
• 11634.911
• 39434.0
• 23234.0
• 35034.0
• 11834.0
• 28234.0
• 39634.999

RelVals-INPUT

• 138.4138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3/step2_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3.log
• 138.5138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3/step2_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3.log

[abdoulline]

@lwang046 that's what I meant, when asked:
did you run regular runTheMatrix -l limited before submitting PR?
Let's get back to e-mail thread.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37537/29308

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #37537 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75958c/23990/summary.html
COMMIT: b2891e0
CMSSW: CMSSW_12_4_X_2022-04-18-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37537/23990/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3589937
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3589907
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

enable gpu

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75958c/23997/summary.html
COMMIT: b2891e0
CMSSW: CMSSW_12_4_X_2022-04-18-2300/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37537/23997/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19874
• DQMHistoTests: Total failures: 955
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 18919
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3589937
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3589913
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[abdoulline]

GPU differences appeared only for 11634.506

11634.506_TTbar_14TeV+2021_Patatrack_PixelOnlyTripletsGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/

https://cmsweb.cern.ch/dqm/dev/session/x6WiPV

Both ECALonly and HCALonly wfs showed no bin-by-bin diff.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1