-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HLT75e33 step to Phase-2 workflows #37324
Conversation
code-checks |
@smuzaffar Do I miss any change to make the code-check for PR test happen? Thanks. |
no you did not miss any change. github itself is going through a bad time ( https://www.githubstatus.com/ ) that is why bot is not reacting to and command |
looks like github is coming back , bot has started the code checks now |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37324/28968
|
test parameters:
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6ae7d/23329/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
This is a side note to @cms-sw/pdmv-l2 that they will face a space increasing for D88 if run with cmsDriver after this PR is merge. Duplication of FEVTDEBUGHLT content after RECO will happen. One can remove the original production of FEVT from RECO step to save relvals space. |
Thanks @srimanob . Do you have an estimate of how much it will increase in size without manual intervention in the wf configuration? |
You will need roughly 20 TB more per standard set of D88 NoPU+PU200. I estimate from TTbar/SUSY which needs ~1TB for GEN-SIM-RECO in both PU scenario. The output from HLT step will completely overlap with RECO with additional information of HLTX step. I assume you have the drop function in RelVals machine. Note that, I plan to make a little update on datatier. So that we will have the same GEN-SIM-RECO for output from HLTX step, and output from RECO which will be dropped can be something else, i.e. FEVT. So, this will be transparent from user point of view. |
Pull request #37324 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6ae7d/23829/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade This PR is to add workflow for HLT Phase-2. The needed PR is fully sign, #37162 |
@cms-sw/pdmv-l2 Could you please check and sign again? |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is to add Phase2 HLT75e33 to Phase-2 workflow. It needs #37162.
PR validation:
Output from the following runTheMatrix works,
runTheMatrix.py --what upgrade -l 39434.75 -t 8 --wm init
if this PR is a backport please specify the original PR and why you need to backport that PR:
After agree on the way to implement, we will need to backport to 12_3_X