-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OT inefficiency] add 0% bad strip scenario to customization function and generate new RelVal workflows #37578
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37578/29332
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@civanch, @jordan-martins, @bbilin, @wajidalikhan, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37578/29344
|
Pull request #37578 was updated. @civanch, @jordan-martins, @bbilin, @wajidalikhan, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-534c27/23959/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1 |
+Upgrade This PR add new 0T workflows to Phase-2 with customization function of no bad strip but the inefficiency due to the bias rail in the macro-pixel sensors. No change is expected in existing PR. New workflow |
hold
|
Pull request has been put on hold by @mmusich |
unhold |
urgent
|
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is a follow-up to PR #37463, introducing a customization function for the scenario in which there is no simulation of the bad strips in the Outer Tracker, but only the inefficiency due to the bias rail in the macro-pixel sensors.
I profit of this PR to add also to the matrix a battery of relvals to exercise the various scenarios.
PR validation:
Run successfully:
runTheMatrix.py --what upgrade -l 23234.111,23234.112,23234.113,23234.114
(when merged together with #37576)Also
runTheMatrix.py --what upgrade --show | grep OT
gives:if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
cc: @emiglior @suchandradutta