Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator hepmc3 products #37187

Merged
merged 5 commits into from
Apr 20, 2022
Merged

Conversation

mkirsano
Copy link
Contributor

@mkirsano mkirsano commented Mar 9, 2022

PR description:

Add generator products corresponding to HepMC3 event record. They are not yet added to edm

PR validation:

These products are not yet used.
Used in a local prototype of Pythia8Interface that uses both HepMC2 and HepMC3

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2022

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37187/28762

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37187/28769

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@smuzaffar
Copy link
Contributor

code-checks with cms.week1.PR_0525f52f/52.0-78c28557adab64659c80be19da18577c

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37187/28770

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37187/28778

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@mkirsano
Copy link
Contributor Author

mkirsano commented Apr 8, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4fb28/23773/summary.html
COMMIT: 0a4957f
CMSSW: CMSSW_12_4_X_2022-04-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37187/23773/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3593003
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Apr 9, 2022

@GurpreetSinghChahal, @SiewYan, can you, please, consider this PR comment or sign.

@qliphy
Copy link
Contributor

qliphy commented Apr 19, 2022

ping @cms-sw/generators-l2

@Saptaparna
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 20, 2022

+1
as discussed at yesterday's ORP

@qliphy
Copy link
Contributor

qliphy commented Apr 20, 2022

smuzaffar added a commit to cms-sw/cmsdist that referenced this pull request Apr 20, 2022
smuzaffar added a commit to cms-sw/cmsdist that referenced this pull request Apr 20, 2022
@smuzaffar
Copy link
Contributor

@qliphy , this should be fixed by cms-sw/cmsdist#7801 . As SimDataFormats/GeneratorProducts ( which is part of fwlite build) now depend on hepmc3 so we should include it in fwlite distribution too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants