-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generator hepmc3 products #37187
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37187/28762
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37187/28769
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
code-checks with cms.week1.PR_0525f52f/52.0-78c28557adab64659c80be19da18577c |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37187/28770
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37187/28778
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4fb28/23773/summary.html Comparison SummarySummary:
|
@GurpreetSinghChahal, @SiewYan, can you, please, consider this PR comment or sign. |
ping @cms-sw/generators-l2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
We got an FWlite error @mkirsano please have a look. Thanks! |
[FWLite] added hepmc3 deps needed due to cms-sw/cmssw#37187
@qliphy , this should be fixed by cms-sw/cmsdist#7801 . As SimDataFormats/GeneratorProducts ( which is part of fwlite build) now depend on |
PR description:
Add generator products corresponding to HepMC3 event record. They are not yet added to edm
PR validation:
These products are not yet used.
Used in a local prototype of Pythia8Interface that uses both HepMC2 and HepMC3
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: