[master] Drop references to legacy generators

[iarspider]

PR description:

Drop references to legacy generators. Forward port of PRs opened for DEVEL_X branch.

Original PRs: #37610, #37611, #37612, #37616;
cmsdist PR: cms-sw/cmsdist#7844

PR validation:

Validated in the original PRs and in DEVEL IBs

[iarspider]

please test with cms-sw/cmsdist#7844

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37813/29729

• This PR adds an extra 8KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37813/29729/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37813/29729/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37813/29732

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• FWCore/Concurrency (core)
• GeneratorInterface/CascadeInterface (generators)
• GeneratorInterface/ExternalDecays (generators)
• GeneratorInterface/Herwig6Interface (generators)
• GeneratorInterface/MCatNLOInterface (generators)
• GeneratorInterface/PhotosInterface (generators)
• GeneratorInterface/PomwigInterface (generators)
• PhysicsTools/JetMCAlgos (analysis)

@SiewYan, @smuzaffar, @Dr15Jones, @mkirsano, @makortel, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez, @santocch can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @mkirsano, @makortel, @wddgit, @JyothsnaKomaragiri, @alberto-sanchez, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test with cms-sw/cmsdist#7844

[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3762f/24475/summary.html
COMMIT: 3320b41
CMSSW: CMSSW_12_4_X_2022-05-05-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37813/24475/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @makortel Avoid hiding base class writeCfi_() functions in ParameterDescription<T> #37807
• @Pruthvi-ch v17 Partial wafer implementation #37787
• @swagata87 Remove unused variable use_preshower from PFECALSuperClusterProducer #37756
• @iarspider Update cppCommentSkipper: don't log the exact error #37809
• @Dr15Jones Give more context in case of an ExternalGenerator error #37769

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3762f/24475/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3762f/24475/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2970 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3700704
• DQMHistoTests: Total failures: 6318
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3694364
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3762f/24491/summary.html
COMMIT: 3320b41
CMSSW: CMSSW_12_4_X_2022-05-05-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37813/24491/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @jeongeun Cleanup redundant edm ParameterSet exist in RecoVertex #37772

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3762f/24491/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3762f/24491/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2968 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3700704
• DQMHistoTests: Total failures: 6312
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3694370
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[smuzaffar]

@cms-sw/generators-l2 , any idea why there are a lot of dqm comparison differences for workflow 9.0 ?

[makortel]

any idea why there are a lot of dqm comparison differences for workflow 9.0 ?

These occurred also in #37592 (comment) (which was purely technical). I guessed (without any investigation) it might be related to #34448, but given the affected workflow was always 9.0, maybe it could be related to the generator setup of that workflow.

[smuzaffar]

@cms-sw/generators-l2 @cms-sw/analysis-l2 can you please review this? This has been integrated in DELVEL IBs and all workflows run fine. This update should allow us to drop the legacy generators packages from cmssw distribution

[Saptaparna]

+1 since all the other PRs were fine and merged. @SiewYan thanks for running the tests!

[perrotta]

@cms-sw/generators-l2 @cms-sw/analysis-l2 can you please review this? This has been integrated in DELVEL IBs and all workflows run fine. This update should allow us to drop the legacy generators packages from cmssw distribution

@smuzaffar analysis signature is dummy.
As orp I am fine with this PR, and I will merge it together with https://github.com/cms-sw/cmsdist/pull/7844/files as soon as it will get signed by @cms-sw/core-l2

[makortel]

+core

[perrotta]

+1

[perrotta]

merge

[santocch]

+1