-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup redundant edm ParameterSet exist in RecoVertex #37772
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37772/29668
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-069e85/24400/summary.html Comparison SummarySummary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
(Technical PR) Optimization of the module configurations: Improve maintainability by cleaning up redundant cases of edm::ParameterSet calls to
existAs
orexist
for tracked parameters, where redundancy is based on the value being already defined byfillDescriptions
.As follow the previous PR36746, PR36989, PR37313, PR37314, and PR37548.
The list of all calls of
existAs
orexist
are automatically available in the Static Analyzer report. (Bug: CMS code rules)It is accessible from IB page. https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/
For this task consider only modules or tools used by the modules that define
fillDescriptions
.In this PR, 2 files were changed.
RecoVertex/PrimaryVertexProducer/plugins/PrimaryVertexProducer.cc
RecoVertex/PrimaryVertexProducer/src/PrimaryVertexProducerAlgorithm.cc
Here, the "vertexCollections" ParameterSet was provided in a
fillDescription
.cfipython : cfipython/RecoVertex/PrimaryVertexProducer/primaryVertexProducer_cfi.py
PR validation:
Tested in CMSSW_12_4_X, the basic test all passed in the CMSSW PR instructions