EMTF NN version update #37825
Merged
EMTF NN version update #37825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37825/29742
|
|
A new Pull Request was created by @eyigitba for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
|
-1 Failed Tests: RelVals RelVals-INPUT AddOn RelValsExpand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
AddOn TestsExpand to see more addon errors ... |
|
This PR requires cms-data/L1Trigger-L1TMuon#22 to work. Can you please add that to the testing parameters? Thanks! |
|
please test with cms-data/L1Trigger-L1TMuon#22 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba32ce/24492/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
+l1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
perrotta
reviewed
May 6, 2022
| @@ -21,8 +21,8 @@ void PtAssignmentEngineDxy::configure(int verbose, const std::string pbFileNameD | |||
| pbFileNameDxy_ = pbFileNameDxy; | |||
| std::string pbFilePathDxy_ = "L1Trigger/L1TMuon/data/emtf_luts/" + pbFileNameDxy_; | |||
|
|
|||
| inputNameDxy_ = "batch_normalization_1_input"; | |||
| outputNamesDxy_ = {"dense_4/BiasAdd"}; | |||
| inputNameDxy_ = "input1"; | |||
There was a problem hiding this comment.
Are changes in this file related to the update of the EMTF displaced NN?
There was a problem hiding this comment.
Yes. The names of the input and output nodes changed in the new protobuf file. The changes are made to adapt to that.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR updates the version of the data file for the EMTF displaced NN
v10.1. The previous version is outdated, and needs to replaced with the version available in firmware at P5. Some performance changes are expected with respect to the old versionv5PR validation:
Validated with
runTheMatrix.py -l limited -i all --ibeos.if this PR is a backport please specify the original PR and why you need to backport that PR:
This change requires cms-data/L1Trigger-L1TMuon#22 to work