Remove unnecessary edm ParameterSet existAs or exist in RecoMuon/{L2MuonProducer}

[jeongeun]

PR description:

Optimization of the module configurations: Improve maintainability by cleaning up the unnecessary "Function edm::ParameterSet::exists() or edm::ParameterSet::existsAs<>() " in the module configuration in C++ code.

This check is automatically available in the static analyzer*. (Bug: CMS code rules)
*https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_12_3_X_2022-01-18-2300/slc7_amd64_gcc10/llvm-analysis/

In this PR, 1 file was changed.
RecoMuon/L2MuonProducer/plugins/L2MuonProducer.cc

MuonTrajectoryBuilder is already exist in the default cfipython file**
** cfipython/RecoMuon/L2MuonProducer/L2MuonProducer_cfi.py
L105 MuonTrajectoryBuilder = cms.string('Exhaustive'),

PR validation:

Tested in CMSSW_12_2_X, the basic test all passed in the CMSSW PR instructions.

[cmsbuild]

@jeongeun, CMSSW_12_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36746/27853

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

• RecoMuon/L2MuonProducer (hlt, reconstruction)

@Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please review it and eventually sign? Thanks.
@HuguesBrun, @bellan, @silviodonato, @abbiendi, @Fedespring, @calderona, @sscruz, @jhgoh, @CeliaFernandez, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26021c/21810/summary.html
COMMIT: 3cbfe50
CMSSW: CMSSW_12_3_X_2022-01-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36746/21810/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3464860
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3464832
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[missirol]

MuonTrajectoryBuilder is already exist in the default cfipython file

In my understanding, the point is that L2MuonProducer.cc#L286 already defines that parameter in a fillDescriptions method, so there is no way for parameterSet.existsAs<string>("MuonTrajectoryBuilder") to be false, irrespective of how the python module is configured.

[missirol]

+hlt

[slava77]

+reconstruction

for #36746 3cbfe50

• code changes are in line with the PR description. This cleanup of existsAs is valid following the completion of the cleanup of instances in cms-sw/cmssw repo of instances of L2MuonProduce made from scratch (not using the default cfipython/fillDescriptions source). While the cfipython/fillDescriptions defines a default different from the default in the constructor, the only direct use case to RecoMuon/L2MuonProducer/python/L2Muons_cfi.py resets that value to the same as in the original constructor.
• jenkins tests pass and comparisons with the baseline show no relevant differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Technical PR, which will not imply any change whatsoever in HLT or reco outputs: this PR can be safely merged for 12_3_0_pre4, even if pre4 is only intended to integrate the updated/fixed Run3 geometry

[perrotta]

merge