Give more context in case of an ExternalGenerator error

[Dr15Jones]

PR description:

• Added extra information to error output when there was a problem with the external application.

We are seeing infrequent errors in the IB and I was hoping to get a bit more context to help diagnose what is happening.

PR validation:

Please test.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37769/29659

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• GeneratorInterface/Core (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6218d7/24394/summary.html
COMMIT: b6c013b
CMSSW: CMSSW_12_4_X_2022-05-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37769/24394/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3703092
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3703056
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[SiewYan]

@Dr15Jones , the test [*] suggested that:

Non-const variable 'std::string s_uniqueID' is static and might be thread-unsafe

not sure will it break in application..

[*] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6218d7/24394/llvm-analysis/report-f9d975.html#EndPath

[SiewYan]

The fail test is working [*], its looking ok for me.

[*] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6218d7/24394/unitTests/src/GeneratorInterface/Core/test/FailingGeneratorFilterTest/testing.log

[SiewYan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@Dr15Jones indeed I share the same doubt as @SiewYan : is the newly defined s_uniqueID thread safe?

[Dr15Jones]

@SiewYan @perrotta

Non-const variable 'std::string s_uniqueID' is static and might be thread-unsafe

Sorry for not getting back sooner. Within cmsRun, this would definitely be a concern. In this case, this is part of the external application and that application only uses 1 thread (since it is running an instance of a non-thread safe generator). I've properly annotated the variable so the test should pass now.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37769/29712

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #37769 was updated. @alberto-sanchez, @SiewYan, @mkirsano, @Saptaparna, @GurpreetSinghChahal can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6218d7/24444/summary.html
COMMIT: d9b1623
CMSSW: CMSSW_12_4_X_2022-05-04-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37769/24444/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
39434.501 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3700548
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3700518
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[SiewYan]

Thank you @Dr15Jones for the correction! However i found another similar thread safety issue on s_sharedLock [*], is this expected too or should this be annotated?

Thanks

[*] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6218d7/24444/llvm-analysis/report-630c05.html#EndPath

[Dr15Jones]

@SiewYan thanks for looking at the PR issues! As it is still part of the same single threaded application (externalGenerator) thread safety is not an issue (plus has been there since the beginning).

Do you want me to add the same annotation in the PR or do it in another PR?

[SiewYan]

+1

@Dr15Jones , you may add the same annotation in another PR though, for completeness. This PR is good to go. Thanks!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1