add HLT-EGM customisation for 2018 Data

[missirol]

PR description:

This PR updates the function customiseFor2018Input used by TSG to characterise the Run-3 HLT menu on 2018 collisions data.

It adds a function named customiseEGammaRecoFor2018Input, which currently sets the flag regTrainedWithPS to False to handle correctly the HLT-EGM energy regression tags of 2018 [*].

#37588 changed the value of regTrainedWithPS to true for Run 3 via the source code. This PR updates the Run-2 customisation such that TSG studies using customiseFor2018Input are not affected by #37588.

If #37588 is backported to 12_3_X, this PR will have to be backported as well.

No changes expected. Note that PR tests are completely blind to the modifications in this PR.

[*] If it turns out that the preferred approach is to instead use the Run-3 tags on 2018 data (keeping regTrainedWithPS=true), customiseEGammaRecoFor2018Input could be updated in the future to overwrite the relevant GT tags instead of changing the value of the regTrainedWithPS flag.

FYI: @cms-sw/egamma-pog-l2

PR validation:

Validated with manual tests based on TSG recipes.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37606/29380

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[missirol]

urgent

"urgent" here means that, ideally, this PR would go in 12_4_0_pre3 together with #37588.

This PR poses no risk for IBs or release-building (this function is not used anywhere centrally).

This PR simply allows TSG recipes to remain correct as other parts of the source code change.

[missirol]

please test

[swagata87]

Thanks Marino for taking care of it.

If it turns out that the preferred approach is to instead use the Run-3 tags on 2018 data (keeping regTrainedWithPS=true), customiseEGammaRecoFor2018Input could be updated in the future to overwrite the relevant GT tags instead of changing the value of the regTrainedWithPS flag.

yes we would like to check the rates with regTrainedWithPS=true and using Run3 regression tags in GT by running on 2018 data, just to get an idea of how much the rate increases due to energy correction. This will give us a better idea of egamma HLT rates to be expected in early Run3. We can coordinate among ourselves about how to proceed with that.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6987d/23988/summary.html
COMMIT: 98ac9d0
CMSSW: CMSSW_12_4_X_2022-04-18-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37606/23988/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3589937
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3589907
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

• update of a customisation function used by TSG for HLT studies with Run-2 Data
• this function is not used anywhere centrally, so this PR poses no risks for IBs
• this PR is prompted by Updating EGM HLT supercluster regression tags for Run 3 in MC #37588 , and it should be integrated before, or together with, the latter (there is no downside merging this PR before Updating EGM HLT supercluster regression tags for Run 3 in MC #37588)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1