Add copyright comment to source files #42

efekarakus · 2019-09-16T21:53:50Z

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…980)  Fix #979  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add general sidecar support for svc deployment. With this change now users can configure sidecar in their manifest then do `svc deploy` to deploy their service with sidecar containers. Manual test pass (deployed a service with nginx as a sidecar container). Next step is to add Firelens deployment and lastly add e2e tests for this feature.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Adds execute method which renders user inputs into cloudformation template in addons dir.  addresses #769 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The ability to parse Healthcheck options from a user's dockerfile. Also added, some of Moby buildkit packages for ease of parsing dockerfile. https://godoc.org/github.com/moby/buildkit/frontend/dockerfile/parser https://godoc.org/github.com/moby/buildkit/frontend/dockerfile/instructions  Addresses #938 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. Binary Size (added Mobykit parsers) Before: 44.2 MB After: 44.4 MB

This PR adds the cloudformation template necessary to create DDB tables on behalf of customers in storage init.  Addresses #769 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

With #980, we fixed an issue which occurred when there were multiple dockerfiles present in the build directory. However, this may have broken our end to end tests, because the call to Docker was formatted as the following: ```sh docker build -t <imageTag> path/to -f Dockerfile ``` This should be fine, but the end to end tests began to fail on Monday with the following output: ```bash addons flow when deploying svc svc deploy should succeed /github.com/aws/amazon-ecs-cli-v2/e2e/addons/addons_test.go:145 unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /github.com/aws/amazon-ecs-cli-v2/e2e/addons/Dockerfile: no such file or directory Error: build Dockerfile at ./hello/Dockerfile with tag gallopinggurdey: building image: exit status 1 ``` This indicates that although the Dockerfile path was set to `hello/Dockerfile`, Docker was looking for the file somewhere in the root directory of that path (.) and subsequently failing. This fix always sets the dockerfile path to be relative to the *root* of the docker build context, not the *leaf* of the build context. (previously we were parsing paths like `path/to/dockerfile` into `path/to` and `dockerfile`, assuming that the dockerfile would be searched for in `path/to`, not `path`. This was incorrect.) The new behavior is to call: ```sh docker build -t <imageTag> path/to -f path/to/dockerfile ```  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Partially address #875. With this PR now we can deploy a Copilot service with Firelens as the log driver to deliver logs of the main container to destinations. Users can config Firelens in two ways: 1. Set up configurations in the manifest (unable to sent to multiple destinations though). 2. Configure using fluentbit config file. Note that this requires users to build their own custom fluentbit image and specifying their config file path. Additionally users might need to add permissions to task role if necessary. And they are able to add their own permissions by using Copilot addons feature. Any addons policy will be added to the task role. This PR also adjusts `svc logs` to accommodate Firelens changes.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixes #1008. (I'm gonna rest in peace. Put the e2e test log on my grave and don't include any PR reviews other than LGTM)  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixes #1004.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…xecution. (#1025) This PR completes the implementation of `storage init`'s Execute() method. Notable changes: * Adds S3 and DynamoDB structs to the addons package which behave similarly to those in the `manifest.LoadBalancedWebService` and `manifest.BackendService` structs. * Leverages the new AddonsWriter interface (with tiny modification) in `workspace` to enable template parsing for DDB and S3. * Resolves several typos in the DDB template which would have rendered it undeployable Unit tests forthcoming.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Quick fix to get rid of the unexpected period at the end of the log output when there's no service found in the app.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…1035)  This PR adds template functions to the storage resource CF templates. We now only need to specify a resource name to the DynamoDB and S3 types, and template functions StorageLogicalIDSafe and EnvVarName will properly construct CF resource names and Env Vars. This PR also reorganizes and renames some common go template functions that previously lived in the "deploy/cloudformation/stack" package, moving them to the "template" package. Finally, it changes the implementation of ToSnakeCase to better match StringsWithUPPERCase (now renders as "STRINGS_WITH_UPPER_CASE" instead of "STRINGS_WITH_U_P_P_E_R_CASE")  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This PR removes the notion of an Attribute from the UI of `copilot storage init`. Previously, customers could specify extra attributes via the `--att` flag which they could specify for use in Local Secondary Indices. This is problematic, however, because DynamoDB does not allow unused attributes to be written in the CF template and this would cause the addons stack deployment to fail. Removing "attribute" as a customer facing concept simplifies the user experience by only asking for "alternate sort keys/LSIs" and allows us to avoid complex validation issues which arise when extra attributes are specified.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This command removes the orphaned "Addons" group from the `copilot -h` help menu.   By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This PR has two major changes: 1. add ask to task run; 2. add a required flag for task-family name, update validate and ask correspondingly  Related #702 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Related: #918   By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Previously, we were converting timestamps into int64 types on Status structs. This change preserves the timestamp fields in time format, which makes timestamp fields in the JSONString output consistent with other JSON payloads (e.g. pipeline_show). It also simplifies the HumanString output logic. This also includes a refactor of timestamps on Pipelines to use values rather than pointers.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…alse (#1057)  This change solves an issue where if a customer selected "No" when asked "Would you like to add any alternate sort keys to this DynamoDB table?", the `noLsi` option was not properly set and an erroneous line was injected into the CF template.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…age init (#1063)  This PR changes `storage init` to use the WorkspaceSelector instead of the Application-wide ServiceSelector. Addresses #1054  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Partially address #1069. Add service deployment info APIs to `deploy` pkg.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Part of #1069. Fixes #1003.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add homebrew install directions   By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

)   By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Part of aws#2588.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

)   By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Continued from aws#2705.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…#2781)  fixes aws#2776  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Compile and publish darwin/arm64 copilot CLI binary. - This will allow copilot to run natively on newer macs rather than being emulated. I've tested the binary compilation but not sure if I can test the actual release build specs easily. Resolves aws#2745  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This fixes the PR template to specify the Apache 2.0 License rather than leaving it the default "under the terms of your choice".  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License..

Part of aws#2818. This PR adds boilerplate for new manifest validation for LB svc. Also added validation for mutually exclusive fields. Will add for the other workload types, advanced type validation, and consolidate existing validations in following PRs  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License..

…s#2826)  Part of aws#2818. After this PR, we should have boilerplate completed for every workload type. Then, we'll add more advanced basic types validation as well as start to consolidate validation elsewhere.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License..

This (hopefully) can fix the broken [homebrew formula](https://formulae.brew.sh/formula/copilot). Reason behind this (I guess) is the formula uses [`make build`](https://github.com/Homebrew/homebrew-core/blob/master/Formula/copilot.rb#L33) which doesn't include `CGO_ENABLED=0` and by default it is set to be `1`, resulting in the fact that the generated binary is not static. However, our GitHub release doesn't suffer from the same issue because we use `make release` which has `CGO_ENABLED=0` set in all platform versions.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

Fixed typo in `copilot env init` that there's space in subnet id. `subnet -014661ebb7ab8681a ` ```bash $ copilot env init --help ... Creates an environment with imported VPC resources. `$ copilot env init --import-vpc-id vpc-099c32d2b98cdcf47 \` `--import-public-subnets subnet-013e8b691862966cf,subnet -014661ebb7ab8681a \` `--import-private-subnets subnet-055fafef48fb3c547,subnet-00c9e76f288363e7f` ```  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

fixes aws#2723.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License..

Ginkgo ran 1 suite in 1h2m12.927815182s  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

Fix dependabot alert  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

…ws#2859)  Pushing to ECR concurrently would fail because of the following reason. We should retry in our e2e custom domain suite. ``` The push refers to repository [1234567890.dkr.ecr.us-west-2.amazonaws.com/e2e-domain-1632160296/frontend] -- 863 | d164a303952c: Preparing 864 | fac15b2caa0c: Preparing 865 | f8bf5746ac5a: Preparing 866 | d11eedadbd34: Preparing 867 | 797e583d8c50: Preparing 868 | bf9ce92e8516: Preparing 869 | d000633a5681: Preparing 870 | bf9ce92e8516: Waiting 871 | 797e583d8c50: Waiting 872 | d000633a5681: Waiting 873 | d11eedadbd34: Waiting 874 | f8bf5746ac5a: Waiting 875 | no basic auth credentials 876 | ✘ build and push image: push to repo e2e-domain-1632160296/frontend: docker push 1234567890.dkr.ecr.us-west-2.amazonaws.com/e2e-domain-1632160296/frontend:frontend: exit status 1 ```  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

Part of aws#2818. This PR adds advanced types validation for - percentage - platform - placement - IP Note that this PR doesn't move any existing validation in `UnmarshalYAML`.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

)  This PR - upgrade `UnmarshalYAML` to yaml v3 because of go-yaml/yaml#125 (comment) - add `UnmarshalYAML` for `Image` to validate mutual exclusive fields before applying env override. - Revert `Image` struct [embedding](https://golang.org/doc/effective_go#embedding) in `ImageWithHealthcheck` and `ImageWithPort`, as `UnmarshalYAML` would be wrongly taken as the method of its parent, causing the other fields in its parent struct (e.g., `Port` and `HealthCheck`) to be set `nil` unexpectedly. go-yaml/yaml#263 (comment)  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

…ws#2869)  part of aws#2818  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

Part of aws#2818. This PR adds validation for - task def override - sidecar mount points - storage config - publish/subscribe Also make `topic.queue` to able to accept either bool or map as input so as users can better specify a topic specific queue with default config.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

Part of aws#2818  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

On Windows, colors are not enabled. This change enable colors. ![image](https://user-images.githubusercontent.com/10111/136043356-dcf6534b-6d03-48a2-ae10-5e1f20cbd136.png) ![image](https://user-images.githubusercontent.com/10111/136043405-0f86fa79-bac8-4bb5-b968-26cf8e2bbcc0.png)  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

…date (aws#2895)  This PR 1. Add integ test to make sure every manifest struct or advanced type implements `Validate()`. 2. Fix a bug that `network.placement` should not be required even if `network` is not empty.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

Add copyright comment to source files

7fd8037

efekarakus requested review from kohidave, hencrice, sonofachamp and a team September 16, 2019 21:53

kohidave approved these changes Sep 16, 2019

View reviewed changes

kohidave merged commit 0efc020 into aws:master Sep 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add copyright comment to source files #42

Add copyright comment to source files #42

efekarakus commented Sep 16, 2019

Add copyright comment to source files #42

Add copyright comment to source files #42

Conversation

efekarakus commented Sep 16, 2019