Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only accepts dockerfile named Dockerfile #979

Closed
Louise15926 opened this issue May 29, 2020 · 1 comment · Fixed by #980
Closed

Only accepts dockerfile named Dockerfile #979

Louise15926 opened this issue May 29, 2020 · 1 comment · Fixed by #980
Assignees
Labels
type/bug Issues that are bugs.

Comments

@Louise15926
Copy link
Contributor

Current Behavior

If I name my dockerfile something other than 'Dockerfile' (say 'db.Dockerfile'), during app deploy it will give me this error: "unable to prepare context: context must be a directory".

$ ecs-preview app init --dockerfile "db.Dockerfile"
$ ecs-preview app deploy # throws error

Expected Behavior

Not throwing this error

@iamhopaul123
Copy link
Contributor

iamhopaul123 commented May 29, 2020

Plus, if dockerfile path is not passed in by a flag then "pb.Dockerfile" cannot be recognized and listed when selecting which dockerfile to use.

But maybe this is expected because they can name their dockerfile to whatever name they'd like to use 🤷‍♂️

@mergify mergify bot closed this as completed in #980 Jun 1, 2020
mergify bot pushed a commit that referenced this issue Jun 1, 2020
…980)

<!-- Provide summary of changes -->
Fix #979
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Issues that are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants