Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidecars e2e tests #1008

Closed
iamhopaul123 opened this issue Jun 9, 2020 · 0 comments · Fixed by #1011
Closed

Sidecars e2e tests #1008

iamhopaul123 opened this issue Jun 9, 2020 · 0 comments · Fixed by #1011
Labels
type/design Issues that are design proposals. type/test Issues that are for improving our test coverage.

Comments

@iamhopaul123
Copy link
Contributor

iamhopaul123 commented Jun 9, 2020 •
edited
Loading

Part of #875. Now that we have sidecars support available in Copilot. Some e2e tests are required to make sure this feature works properly:

  • nginx sidecar container for sidecar example. this example also allows testing for route traffic to the container other than main container.
  • enable firelens as main container's log driver.
@iamhopaul123 iamhopaul123 added type/design Issues that are design proposals. type/test Issues that are for improving our test coverage. labels Jun 9, 2020
@iamhopaul123 iamhopaul123 mentioned this issue Jun 10, 2020
Merged
@mergify mergify bot closed this as completed in #1011 Jun 11, 2020
mergify bot pushed a commit that referenced this issue Jun 11, 2020
@iamhopaul123
chore(e2e): add e2e tests for sidecars (#1011)
165c106 
<!-- Provide summary of changes -->
Fixes #1008.

(I'm gonna rest in peace. Put the e2e test log on my grave and don't include any PR reviews other than LGTM)
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/design Issues that are design proposals. type/test Issues that are for improving our test coverage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(e2e): add e2e tests for sidecars iamhopaul123/amazon-ecs-cli-v2
1 participant
@iamhopaul123