Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update set-value to >=4.0.1 #2849

Merged
merged 3 commits into from
Sep 17, 2021

Conversation

iamhopaul123
Copy link
Contributor

Fix dependabot alert

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner September 17, 2021 17:02
@iamhopaul123 iamhopaul123 requested review from Lou1415926 and removed request for a team September 17, 2021 17:02
@iamhopaul123 iamhopaul123 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Sep 17, 2021
@@ -2501,7 +2501,7 @@
"get-value": "^2.0.6",
"has-value": "^1.0.0",
"isobject": "^3.0.1",
"set-value": "^2.0.0",
"set-value": ">=4.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we be updating the dependencies section instead of modifying package-lock?
https://github.com/aws/copilot-cli/blob/mainline/cf-custom-resources/package.json#L25

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's why i put the label before 😃 now fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still didn't add it to the package file because we don't directly depend on that package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But won't it get overridden, I don't get how it's fixed 😅
My understanding is that package-lock isnt' meant to be modified manually. If we ever upgrade a dependency in package.json, and run npm install then I think it will reset these changes, I'd expected the following to be our enforcing mechanism:

"dependencies": {
   "set-value": ">=4.0.1",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm i tried to do npm install and it didn't revert the change. But sure I'll just add it to package.json

@iamhopaul123 iamhopaul123 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Sep 17, 2021
@efekarakus efekarakus added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Sep 17, 2021
@iamhopaul123 iamhopaul123 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Sep 17, 2021
@mergify mergify bot merged commit 72bbae4 into aws:mainline Sep 17, 2021
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
<!-- Provide summary of changes -->
Fix dependabot alert
<!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants