-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update set-value to >=4.0.1 #2849
Conversation
@@ -2501,7 +2501,7 @@ | |||
"get-value": "^2.0.6", | |||
"has-value": "^1.0.0", | |||
"isobject": "^3.0.1", | |||
"set-value": "^2.0.0", | |||
"set-value": ">=4.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we be updating the dependencies
section instead of modifying package-lock
?
https://github.com/aws/copilot-cli/blob/mainline/cf-custom-resources/package.json#L25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that's why i put the label before 😃 now fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still didn't add it to the package file because we don't directly depend on that package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But won't it get overridden, I don't get how it's fixed 😅
My understanding is that package-lock
isnt' meant to be modified manually. If we ever upgrade a dependency in package.json
, and run npm install
then I think it will reset these changes, I'd expected the following to be our enforcing mechanism:
"dependencies": {
"set-value": ">=4.0.1",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm i tried to do npm install
and it didn't revert the change. But sure I'll just add it to package.json
d815f4c
to
31d58c0
Compare
Fix dependabot alert
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.