Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade golang to 1.17 #2894

Merged
merged 2 commits into from
Oct 5, 2021
Merged

chore: upgrade golang to 1.17 #2894

merged 2 commits into from
Oct 5, 2021

Conversation

iamhopaul123
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner October 4, 2021 21:50
@iamhopaul123 iamhopaul123 requested review from efekarakus and removed request for a team October 4, 2021 21:50
efekarakus
efekarakus reviewed Oct 4, 2021
View reviewed changes
go.mod
@@ -1,6 +1,6 @@
module github.com/aws/copilot-cli

go 1.16
go 1.17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to upgrade all the buildspecs too!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

@efekarakus efekarakus added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Oct 4, 2021
@iamhopaul123 iamhopaul123 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Oct 4, 2021
@mergify mergify bot merged commit 1461f4d into aws:mainline Oct 5, 2021
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
@iamhopaul123 @thrau
chore: upgrade golang to 1.17 (aws#2894)
a8268ef 
<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huanjani huanjani huanjani approved these changes

@efekarakus efekarakus efekarakus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamhopaul123 @efekarakus @huanjani