Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(manifest): add advanced types validation I #2852

Merged
merged 5 commits into from
Sep 21, 2021

Conversation

iamhopaul123
Copy link
Contributor

@iamhopaul123 iamhopaul123 commented Sep 17, 2021

Part of #2818. This PR adds advanced types validation for

  • percentage
  • platform
  • placement
  • IP

Note that this PR doesn't move any existing validation in UnmarshalYAML.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner September 17, 2021 22:17
@iamhopaul123 iamhopaul123 requested review from efekarakus and removed request for a team September 17, 2021 22:17
Copy link
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some nits on error messages!

internal/pkg/manifest/validate.go Outdated Show resolved Hide resolved
internal/pkg/manifest/validate.go Outdated Show resolved Hide resolved
internal/pkg/manifest/validate.go Outdated Show resolved Hide resolved
internal/pkg/manifest/validate.go Outdated Show resolved Hide resolved
internal/pkg/manifest/validate.go Outdated Show resolved Hide resolved
@iamhopaul123 iamhopaul123 force-pushed the manifest-validation-advanced-1 branch from 1de9e5e to 816a090 Compare September 20, 2021 22:39
Copy link
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

internal/pkg/manifest/validate.go Outdated Show resolved Hide resolved
internal/pkg/manifest/validate.go Outdated Show resolved Hide resolved
internal/pkg/manifest/workload.go Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 3752a06 into aws:mainline Sep 21, 2021
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
<!-- Provide summary of changes -->
Part of aws#2818. This PR adds advanced types validation for
- percentage
- platform
- placement
- IP

Note that this PR doesn't move any existing validation in `UnmarshalYAML`.
<!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants