-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(manifest): add advanced types validation I #2852
Merged
mergify
merged 5 commits into
aws:mainline
from
iamhopaul123:manifest-validation-advanced-1
Sep 21, 2021
Merged
chore(manifest): add advanced types validation I #2852
mergify
merged 5 commits into
aws:mainline
from
iamhopaul123:manifest-validation-advanced-1
Sep 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamhopaul123
requested review from
efekarakus
and removed request for
a team
September 17, 2021 22:17
Lou1415926
reviewed
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some nits on error messages!
iamhopaul123
force-pushed
the
manifest-validation-advanced-1
branch
from
September 20, 2021 22:39
1de9e5e
to
816a090
Compare
Lou1415926
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
efekarakus
reviewed
Sep 21, 2021
efekarakus
approved these changes
Sep 21, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
<!-- Provide summary of changes --> Part of aws#2818. This PR adds advanced types validation for - percentage - platform - placement - IP Note that this PR doesn't move any existing validation in `UnmarshalYAML`. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2818. This PR adds advanced types validation for
Note that this PR doesn't move any existing validation in
UnmarshalYAML
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.