refactor: use timestamps for struct fields #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamhopaul123
approved these changes
Jun 25, 2020
efekarakus
added
the
do-not-merge
SoManyHs
force-pushed
the
refactor-timestamps
branch
from
5758c40 to
dc3ca23
Compare
efekarakus
removed
the
do-not-merge
Use value rather than pointers, as recommended by https://golang.org/pkg/time/#Time
SoManyHs
force-pushed
the
refactor-timestamps
branch
from
dc3ca23 to
9b8c720
Compare
efekarakus
approved these changes
Jun 26, 2020
| @@ -229,7 +230,7 @@ func (s *Service) ServiceStatus() ServiceStatus { | |||
| Status: aws.StringValue(s.Status), | |||
| DesiredCount: aws.Int64Value(s.DesiredCount), | |||
| RunningCount: aws.Int64Value(s.RunningCount), | |||
| LastDeploymentAt: s.Deployments[0].UpdatedAt.Unix(), | |||
| LastDeploymentAt: *s.Deployments[0].UpdatedAt, // FIXME Service assumed to have at least one deployment | |||
There was a problem hiding this comment.
Do we an issue for this? would you mind creating it so we don't forget about it 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were converting timestamps into int64 types on Status structs. This change preserves the timestamp fields in time format, which makes timestamp fields in the JSONString output consistent with other JSON payloads (e.g. pipeline_show). It also simplifies the HumanString output logic.
This also includes a refactor of timestamps on Pipelines to use values rather than pointers.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.