feat: enable colors on Windows #2896
Conversation
There was a problem hiding this comment.
Hi @mattn ! Thank you so much for the contribution, your library is awesome 😍
I just have a question below please 🙇
cmd/copilot/main.go
Outdated
| @@ -25,16 +26,23 @@ func init() { | |||
| cobra.EnableCommandSorting = false // Maintain the order in which we add commands. | |||
| } | |||
|
|
|||
| func main() { | |||
| func run() int { | |||
| defer colorable.EnableColorsStdout(nil)() | |||
There was a problem hiding this comment.
I wonder why it wasn't working before 🤔
We're using the following writers when writing to stdout:
copilot-cli/internal/pkg/term/log/log.go
Lines 23 to 24 in 459f729
which uses your library 🤩 as far as I understand:
https://github.com/fatih/color/blob/a05da93ebe62ca9fc6791d3376ec4dad01196448/color.go#L25-L30
Shouldn't that have been working already or am I misunderstanding how colorable.NewColorableStdout() works?
There was a problem hiding this comment.
Ah, copilot-cli already use go-colorable. Okay, I'll fix in another way soon.
|
Side note, is it possible to update the commit like this: |
|
I'll squash commits if you want. |
Not needed, thank you for the contribution! |
|
Thank you! |
<!-- Provide summary of changes --> On Windows, colors are not enabled. This change enable colors.   <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
On Windows, colors are not enabled. This change enable colors.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.