chore(manifest): upgrade UnmarshalYAML to v3 and add for Image #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamhopaul123
requested review from
efekarakus
and removed request for
a team
efekarakus
approved these changes
Sep 22, 2021
Lou1415926
approved these changes
Sep 22, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
) <!-- Provide summary of changes --> This PR - upgrade `UnmarshalYAML` to yaml v3 because of go-yaml/yaml#125 (comment) - add `UnmarshalYAML` for `Image` to validate mutual exclusive fields before applying env override. - Revert `Image` struct [embedding](https://golang.org/doc/effective_go#embedding) in `ImageWithHealthcheck` and `ImageWithPort`, as `UnmarshalYAML` would be wrongly taken as the method of its parent, causing the other fields in its parent struct (e.g., `Port` and `HealthCheck`) to be set `nil` unexpectedly. go-yaml/yaml#263 (comment) <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
UnmarshalYAMLto yaml v3 because of Unmarshaler interface doesn't work on inlined fields go-yaml/yaml#125 (comment)UnmarshalYAMLforImageto validate mutual exclusive fields before applying env override.Imagestruct embedding inImageWithHealthcheckandImageWithPort, asUnmarshalYAMLwould be wrongly taken as the method of its parent, causing the other fields in its parent struct (e.g.,PortandHealthCheck) to be setnilunexpectedly. Embedded Unmarshaler methods are visible in parent type go-yaml/yaml#263 (comment)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.