Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge]Regenerating SDK based on swagger changes on List/Cancel operation for Azure database and Elastic pool #4105

Closed
wants to merge 394 commits into from

Conversation

payiAzure
Copy link
Contributor

@payiAzure payiAzure commented Mar 5, 2018

Description

This pull request is to regenerating SDK based on a swagger changes on the Azure database and elastic pool 'CancelOperation'/'ListOperation'.

The link to the swagger change pull request is: Azure/azure-rest-api-specs#2520

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

olydis and others added 30 commits August 24, 2017 15:07
* reproing test (deep hiararchy)

* reproing test (base class property)

* fix

* bold move

* tiny improvement to generate.cmd (just making sure you get the same experience even when calling one of the RPs scripts)

* case insensitive property lookup (I guess we're already down that rabbit hole)

* tiny improvement to generate.cmd (mention commit IDs, clarifications)

* tiny improvement to generateMetadata.cmd (handle commit IDs)
… Patch scenario test. Cleaned up PollingState: Obsolete DelayInMillisecond propety, introduced DelayBetweenPolling property that returns TimeSpan. Bumped version. (Azure#3621)
* Ver 1.1.0 initial commit

1. Everything is re-generated with the latest AutoRest (by
generate.cmd).
2. With the latest swagger file change, now Location is a parameter of
the method, not a property of client class, this is a breaking change.
3. Change the UT accordingly.
4. Bump the version to 1.1.0.

* Reversion to 2.0.0.0 as shahabhijeet suggested

Reversion to 2.0.0.0 as shahabhijeet suggested.
…re-rest-api-specs#1526) (Azure#3616)

* sdk for 2017-07-14

* Add recorded test

* Updates csproj and test variable
* Code gen for ADLA

* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429

* This commit is for ADLA

* Code gen for ADLS

* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429

* This commit for ADLS

* Code gen for ADLS (part 2)

* I missed this file!

* Code gen for ADL (part 3)

* Updating to the correct commit number:
Azure/azure-rest-api-specs#1452

* Update Azure Batch to 5.1.0 (Azure#3513)

* Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519)

* Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482)

* Do hydra to swagger specs migration for azure-sdk-for-net

* Fix build failed problem

* update the assemblyinfo file with the updated version 2.6.0

* Revert "update the assemblyinfo file with the updated version 2.6.0"

This reverts commit a33beb0.

* Updata the AssemblyFileVersion to 2.6.0.0

* revert package version

* Make project files concise.

* Add Provider test case

* update the pr with new tests with session records

* remove extra code

* Fix Batch changelog references (Azure#3517)

* Fixing changelog.md

* Fixing up changelog.md

* [DataLake Analytics] Fixing changelog.md

More descriptive and fixing indent issue that was not addressed in the previous commit

* [DataLake Store] Fixing changelog.md

More descriptive and fixing indent issue not addressed in a previous commit

* [DataLake Analytics] Fixing changelog.md

Adding an important note about retrieving a list of jobs and accounts

* Revising custom Job Exists method

* Ran into two regressions in JobOperationTests.cs
* The custom Job Exists method is expecting a non-empty response body to
validate non-existence.  After speaking with a team member who
implemented the service, I can no longer rely on this.  Thus, I am
removing the logic that checks for a non-empty response body.
* Commenting out the test case for listing Jobs with a select parameter.
This is currently being fixed.

* Adding a TODO comment

* Adding this as a reminder to re-enable the test

* [CODE GEN] - Reverting readOnly for two fields

* Code gen based on this very descriptive PR:
Azure/azure-rest-api-specs@e33ebf8

* [CODE GEN] - Updating the version (3.1.0 to 3.1.1)
Makes Id/Name/Type fields readonly by making set private.
* Add Azure container instance net SDK

* Revert unnecessary changes and make version consistent

* remove some unnecessary metadata
* enabling data plane to build on travis

* updates for data plane skds for travis
* Supporting LRO Patch operation. Initial set of tests. Fix for issue#3492

* Fixing a case where LRO PUT will fail during polling. Added test to cover the scenario

* Fixed another scenario where body during polling is empty for a failed status and v1 ARM spec allows it to be empty, but V2.2 ARM spec require failed/cancelled status shoudl accompany error information. Added appropriate tests for the scenarios

* Adding Release notes
* Updating ClientRuntime for publishing

* Updating version tag
- Added code generated from Azure Stream Analytics Swagger spec
containing support for Power BI and Azure Data Lake Store outputs
- Added new tests for Power BI and Azure Data Lake Store outputs
- Reran all tests and updated session records
- Updated SDK version to 2.1.0
* repro

* fix

* cleanup

* generate.cmd accepts actual repo name

* mute mkdir output
* Code gen for ADLA

* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429

* This commit is for ADLA

* Code gen for ADLS

* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429

* This commit for ADLS

* Code gen for ADLS (part 2)

* I missed this file!

* Code gen for ADL (part 3)

* Updating to the correct commit number:
Azure/azure-rest-api-specs#1452

* Update Azure Batch to 5.1.0 (Azure#3513)

* Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519)

* Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482)

* Do hydra to swagger specs migration for azure-sdk-for-net

* Fix build failed problem

* update the assemblyinfo file with the updated version 2.6.0

* Revert "update the assemblyinfo file with the updated version 2.6.0"

This reverts commit a33beb0.

* Updata the AssemblyFileVersion to 2.6.0.0

* revert package version

* Make project files concise.

* Add Provider test case

* update the pr with new tests with session records

* remove extra code

* Fix Batch changelog references (Azure#3517)

* Fixing changelog.md

* Fixing up changelog.md

* [DataLake Analytics] Fixing changelog.md

More descriptive and fixing indent issue that was not addressed in the previous commit

* [DataLake Store] Fixing changelog.md

More descriptive and fixing indent issue not addressed in a previous commit

* [DataLake Analytics] Fixing changelog.md

Adding an important note about retrieving a list of jobs and accounts

* Revising custom Job Exists method

* Ran into two regressions in JobOperationTests.cs
* The custom Job Exists method is expecting a non-empty response body to
validate non-existence.  After speaking with a team member who
implemented the service, I can no longer rely on this.  Thus, I am
removing the logic that checks for a non-empty response body.
* Commenting out the test case for listing Jobs with a select parameter.
This is currently being fixed.

* Adding a TODO comment

* Adding this as a reminder to re-enable the test

* [CODE GEN] - Reverting readOnly for two fields

* Code gen based on this very descriptive PR:
Azure/azure-rest-api-specs@e33ebf8

* [CODE GEN] - Updating the version (3.1.0 to 3.1.1)

* [CODE REFACTOR] - Removing flaky test

* Removing test case: DataLakeUploader_FreshFolderUploadDownload()

* Note: In the near future, the custom ADLS Filesystem code will be
replaced with a new SDK that has its own set of test cases.  The account
management side of ADLS will still remain, however.

* [DOC] - Updating the changelog to describe 3.1.1-preview

* [CODE REFACTOR] - Skipping flaky test

* Skipping the flaky test as opposed to commenting it out
* Also, I forgot to replace a SessionRecord file from last update, so I
doing it now
* Rename networkAcls to network rule set.

* Updated tests.

* Updated version to 7.0.0

* [Storage] Adding support for SKU list operations.

* [Storage] Regenerate with generate.cmd

* [Storage]Updated test session records.
…Action Groups API, and fixing some documentation typos (from Swagger) (Azure#3646)

* Adding ActivityLogAlerts and ActionGroups API calls, PATH operations, and the corresponding unit tests

* Generating code from the 'current' branch of the Swagger specs repo

* Adding scenario tests

* Improving scenario tests and re-recording them

* Making sure the scenario tests point to the more recent version of the Resource Manager dll. Enabling tests for netcoreapp1.1

* Introducing multidimensional metrics API and removing the previous one.

* Reverting netcoreapp1.1 test target since it fails to find the records.

* Returning generate.md to its Azure\psSdkJson6 state

* Re-enabling tests for netcoreapp1.1

* [Monitor] Adding multi-dim metrics API and making sure ActionGroupsOperations do not throw standard exceptions, but return ErrorResponses with more information (PR Azure#1614).

* [Monitor] Fixing documentation typos (from Swagger). Improving the error response for Action Groups API.
- Added explicit setter to set custom HttpClient
- Added property DisableDispose to avoid disposal of HttpClient
- Bumped version to 2.1.1-preview
…Rest.ClientRuntime to 2.3.10 (Azure#3657)

* Added customization on RecoveryServices client and updated Microsoft.Rest.ClientRuntime to 2.3.10

* Reverting Microsoft.Rest.ClientRuntime to 2.3.8

* Removing ClientRuntime Version specification
* test changes and autogenerated

* indentation

* Bumbing up assembly Version

* Licence Header MICROSOFT_MIT_NO_VERSION

* SiteRecovery  Packate Release notes
* Regenerated WebSites SDK from latest Swagger updates

* WebSites SDK - Update assembly file version in AssemblyInfo.cs

* Revisions based on code review. Added release notes to Websites csproj file, removed project.json.
…zure#3679)

* Update to latest version of AutoRest code generator

  - There is currently a bug Azure/autorest#2558 which had to be worked around
    with a hacky script fix, in fixup.ps1. Once that issue is fixed we should remove fixup.ps1.

* Remove PORTABLE from Batch.csproj
* Adding Vision SDK.

* Add Text Analytics SDK.

* Adding Vision

* Removing key.

* Removing unneeded files

* Removing key.

* Hooking up Cognitive SDKs with build.

* Updating Swagger spec.

* Fix build

* Moving files around and adding sub namespace for TA.

* Moving managemenet and dataplane folders into their respective folders.

* Updating csproj and files based on comments.

* Simplifying csprojects

* Move to temp directory

* Move back to dataPlane with right casing

* Move to dataPlane directory

* Fixing presumptive OS specific path convention.

* Adding Assembly.Info for Language

* Adding AssemblyInfo for VIsion

* Updates based on feedback.

* Adding a simple readme.md.
…zure#3689)

* Azure Stack Admin for Commerce, Fabric, and InfrastructureInsights

* Moved AzureStack directory, re-recorded tests

* Fixed generation script

* Fixed bug in Commerce Tests

* Remove changes under SDKs

* Changed casing so that linux build works

* Updated Commerce Tests and Recorded new Data

* Merged Common into each RP

* Removed dirs.proj references
* Code gen for ADLA

* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429

* This commit is for ADLA

* Code gen for ADLS

* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429

* This commit for ADLS

* Code gen for ADLS (part 2)

* I missed this file!

* Code gen for ADL (part 3)

* Updating to the correct commit number:
Azure/azure-rest-api-specs#1452

* Update Azure Batch to 5.1.0 (Azure#3513)

* Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519)

* Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482)

* Do hydra to swagger specs migration for azure-sdk-for-net

* Fix build failed problem

* update the assemblyinfo file with the updated version 2.6.0

* Revert "update the assemblyinfo file with the updated version 2.6.0"

This reverts commit a33beb0.

* Updata the AssemblyFileVersion to 2.6.0.0

* revert package version

* Make project files concise.

* Add Provider test case

* update the pr with new tests with session records

* remove extra code

* Fix Batch changelog references (Azure#3517)

* Fixing changelog.md

* Fixing up changelog.md

* [DataLake Analytics] Fixing changelog.md

More descriptive and fixing indent issue that was not addressed in the previous commit

* [DataLake Store] Fixing changelog.md

More descriptive and fixing indent issue not addressed in a previous commit

* [DataLake Analytics] Fixing changelog.md

Adding an important note about retrieving a list of jobs and accounts

* Revising custom Job Exists method

* Ran into two regressions in JobOperationTests.cs
* The custom Job Exists method is expecting a non-empty response body to
validate non-existence.  After speaking with a team member who
implemented the service, I can no longer rely on this.  Thus, I am
removing the logic that checks for a non-empty response body.
* Commenting out the test case for listing Jobs with a select parameter.
This is currently being fixed.

* Adding a TODO comment

* Adding this as a reminder to re-enable the test

* [CODE GEN] - Reverting readOnly for two fields

* Code gen based on this very descriptive PR:
Azure/azure-rest-api-specs@e33ebf8

* [CODE GEN] - Updating the version (3.1.0 to 3.1.1)

* [CODE REFACTOR] - Removing flaky test

* Removing test case: DataLakeUploader_FreshFolderUploadDownload()

* Note: In the near future, the custom ADLS Filesystem code will be
replaced with a new SDK that has its own set of test cases.  The account
management side of ADLS will still remain, however.

* [DOC] - Updating the changelog to describe 3.1.1-preview

* [CODE REFACTOR] - Skipping flaky test

* Skipping the flaky test as opposed to commenting it out
* Also, I forgot to replace a SessionRecord file from last update, so I
doing it now

* [BUG FIX] - Making JobInnerError object recursively defined

* Based on this PR:
Azure/azure-rest-api-specs#1627

* We are essentially adding one more property to the JobInnerError
object (recursively) in order to capture the additional error
information that's returned by the service

* This added property has been tested successfully by a team member
* [Storage] rename SKUs to Skus

* [Storage] added changelog
… InTune, Gallery SDK out of SDKs directory to tools-->Legacy. (Azure#3697)
brjohnstmsft and others added 23 commits February 5, 2018 17:28
…re#4036)

* [Azure Search] Restoring build script and bumping data plane SDK version

The version bump is in preparation for a series of bug fixes that have been
pending for a long time. The build script change was taken from the old
abandoned vs17Dev branch.

* [Azure Search] Fix for data plane SDK issue: 3309

The FieldBuilder class in the Search .NET SDK now ignores properties marked
with JsonIgnore.

* [Azure Search] GetClient propagates SearchServiceClient's HttpClientHandler

Fixes an issue whereby setting the HttpClientHandler when creating a
SearchServiceClient has no effect on the SearchIndexClient returned by
Indexes.GetClient. This would break scenarios such as enabling GZip
compression, for example.

Now the HttpClientHandler propagates, but the DelegatingHandlers don't since
they can't be cloned and are mutated by the ServiceClient base class
constructor.
…ts (Azure#4053)

Some time ago, we added a check to every Azure Search unit test that uses the
Run() method. This check is intended to ensure that none of our SDK code uses
the global JsonConvert.DefaultSettings, since these can be altered by other
code in the same AppDomain. This was causing issues for customers, and is the
reason we added SafeJsonConvert to ClientRuntime and AutoRest.

The check in the Run() method installs a custom JsonConverter and
ContractResolver that throw exceptions whenever they're called. It does this
using a try/finally block so that the change should only be visible while
running the unit test.

Unfortunately, since JsonConvert.DefaultSettings is global state, this
approach is fragile. For example, running tests in parallel can break this
because some infrastructure such as the VS test runner framework itself uses
JSON.NET in ways that rely on DefaultSettings.

Given the fragility of this approach, we've decided to remove these checks
altogether since they were causing spurious test failures.
* budget and marketplace api

* new generated code for consumption api

* fix subscription usage tests

* budget tests

* fix reservation tests

* re-generate sdk and update budget tests

* add budget tests for resource group name

* re-generate consumption sdk based on new swagger

* update consumption sdk test artifact

* marketplace tests pricesheet tests

* increase major version for consumption net sdk

* tests session records file update for api version bump up

* update package release notes
…talog ACL APIs (Azure#4043)

* [CODE GEN] Account

- Object refactor

* [CODE GEN] Job

* Changing OData Query for Job_List from JobInformation to
JobInformationBasic

* [CODE GEN] Catalog

* Making List_Acl pageable

* [CODE GEN] Metadata

* Updating tests

* Updating tests

* Updating SessionRecords

* [VERSION] 3.2.3-preview to 3.3.0-preview

* [ADLA] CODE GEN -- object refactor

* [CODE GEN] Metadata

* Fixing Account custom code

* [ADLA] - Partial revert - Global parameter to method parameter

* [CODE GEN] Metadata

* Updating tests

* [ADLA] Partial revert for some job APIs

* [CODE GEN] Metadata

* Updating SessionRecords

* [CHANGELOG] Update

* [CODE GEN] Metadata

* Fixing file name manually via git mv
…zure#4049)

* adding dns name label support for azure container instance .net sdk

* update version number

* addressing the comments

* adding the missing metadata file
)

* adding a way to detect test/playback mode. Enabled Retry-After for test mode. Now it is possible to add tests for Retry-After

* updating CR version for CR test projects
* Recreate fork due to multiple issues in Azure/azure-sdk-for-net

* Update upstream per shahabhijeet.

Can you do the following in the below order:
Pull latest from upstream (if you have already done this good)
Execute msbuild.exe build.proj from the repo root
a. This will update the build tools in the current repo
Generate your SDK
Build you sdk at least one from command line of IDE
a. Msbuild.exe build.proj /t:build /p:Scope=SDKs\ProvisioningServices
Update the PR

* PR review requested changes

* Fix typo

* Update to handle if unexpected access policy is used.

* Feedback from shahabhijeet

* Remove AzSdk.RP.props file randomly created

* Regenerate client from latest swagger spec and rerecord tests.

* swagger spec renamed from "provisioningservice" to "deviceprovisioningservice"

* provisioningservices cleanup

* Feedback from @shabhijeet
Azure#4041)

* Add two properties into LinkedIntegrationRuntime and update to latest spec

* Regenerate SDK according the comments

* Update change logs
* [CODE GEN] ADLS

* Removed ErrorDetails.cs -- it was unused
* Account to Accounts for operations
* Explicit parameter objects for creation and update

* [CODE GEN] Metadata

* Fixing custom code for file rename

* Updating tests

* Account refactor
* Permission field of AclStatus from int to string

* Updating tests

* Updating SessionRecords

* [VERSION] 2.3.3-preview to 2.4.0-preview

* [CHANGELOG] Update

* ADLS metadata update

* ADLA metadata update
…ts (Azure#4060)

Two of the JsonSerializationTests modify JsonConvert.DefaultSettings. They do
this in order to validate that SafeJsonConvert does not rely on these
settings.

Before this change, these tests would install a custom JSON converter and
contract resolver that always throw. Unfortunately, other aspects of the test
infrastructure rely on DefaultSettings, so this would sometimes result in
unexpected exceptions being thrown.

The solution is to weaken the effect of changing DefaultSettings. Now, the
SafeJsonConvert tests install a custom converter for their own Model class
that produces incorrect results. Because it's targeted at that class
specifically, it should have no side effects on other code that relies on
DefaultSettings.
…ersion (Azure#4062)

* Search SDK: Re-applying changes from search-4x-preview branch to vs17Dev

I tried rebasing the search-4x-preview branch to vs17Dev, but the results were
very messy, so instead this is just a squash-merge of all the changes. This
should differ from search-4x-preview only in the project files and some minor
test changes to account for behavioral changes in the latest version of
ClientRuntime.

* Search SDK: Fixing failing tests

* Search SDK: Re-recording mocks for the preview SDKs

* Search SDK: Updating copyright dates

* Search SDK: Rename Management SDK project and update build script (Azure#3236)

* Renaming Management.Search to Microsoft.Azure.Management.Search

The package and assembly names were accidentally changed during the VS2017
migration. This fixes it.

* Search SDK: Updating Build-SearchPackages script

* [Azure Search] Bumping preview SDK version to 4.0.2-preview

This new version includes some minor bug fixes that just shipped in the 3.0.5
GA SDK.
…zure#4070)

* add new connector Veritca and Netezza, update Google BigQuery

* add new connector Veritca and Netezza, update Google BigQuery

* update changelog

* resolve conflicts

* update changelog
* ManagementGroups SDK

* Minor changes
…fore publishing (Azure#4077)

* Updating ADF SDK version for the release

* Updating ADF SDK version for the release

* Fixing the version for ADF SDK and updating the release notes

* Updated the version in csproj and AssemblyInfo
* Content moderator update

* modified screen text api

* Updated the version
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

3 similar comments
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@payiAzure payiAzure changed the title Regenerating SDK based on swagger changes on List/Cancel operation for Azure database and Elastic pool [Do not merge]Regenerating SDK based on swagger changes on List/Cancel operation for Azure database and Elastic pool Mar 5, 2018
@payiAzure
Copy link
Contributor Author

pull request was created to merge to the old master branch. so close this one

@payiAzure payiAzure closed this Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.