Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cognitive Services Ver.2.0.0 #3597

Merged
merged 2 commits into from
Aug 28, 2017
Merged

Cognitive Services Ver.2.0.0 #3597

merged 2 commits into from
Aug 28, 2017

Conversation

felixwa
Copy link
Contributor

@felixwa felixwa commented Aug 17, 2017 •
edited
Loading

  1. Everything is re-generated with the latest AutoRest (by
    generate.cmd).
  2. With the latest swagger file change, now Location is a parameter of
    the method, not a property of client class, this is a breaking change.
  3. Change the UT accordingly.
  4. Bump the version to 1.1.0.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@felixwa
Ver 1.1.0 initial commit
284fcd7 
1. Everything is re-generated with the latest AutoRest (by
generate.cmd).
2. With the latest swagger file change, now Location is a parameter of
the method, not a property of client class, this is a breaking change.
3. Change the UT accordingly.
4. Bump the version to 1.1.0.
shahabhijeet
shahabhijeet suggested changes Aug 21, 2017
View reviewed changes
src/SDKs/CognitiveServices/Management.CognitiveServices/Properties/AssemblyInfo.cs Outdated
@@ -7,8 +7,8 @@
[assembly: AssemblyTitle("Microsoft Azure Cognitive Services Management Library")]
[assembly: AssemblyDescription("Provides Microsoft Azure Cognitive Services management functions for managing Microsoft Azure Cognitive Services accounts.")]

[assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyVersion("1.1.0.0")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixwa this is not needed. We usually bump up assemblyverion on major version update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet , you mean both AssemblyVersion and AssemblyFileVersion need not to be changed or only AssemblyVersion need not to be changed?
Note this PR introduced a breaking change (Location from property to method parameter) so we definitely need re-versioning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixwa what is the usual practice is, you only update AssemblyVersion when you update the major version.
If you have introduced a breaking change, then simply update
AssemblyFileVersion to 2.0.0.0
AssemblyVersion to 2.0.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet , okay then I have reversioned everything to 2.0.0.0

@shahabhijeet
Copy link
Member

@azuresdkci test this please

@felixwa
Reversion to 2.0.0.0 as shahabhijeet suggested
0ca28ce 
Reversion to 2.0.0.0 as shahabhijeet suggested.
@felixwa felixwa changed the title Cognitive Services Ver.1.1.0 Cognitive Services Ver.2.0.0 Aug 23, 2017
@shahabhijeet shahabhijeet merged commit 7f5fd3a into Azure:psSdkJson6 Aug 28, 2017
JasonYang-MSFT pushed a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
@felixwa @JasonYang-MSFT
Cognitive Services Ver.2.0.0 (Azure#3597)
10ab576 
* Ver 1.1.0 initial commit

1. Everything is re-generated with the latest AutoRest (by
generate.cmd).
2. With the latest swagger file change, now Location is a parameter of
the method, not a property of client class, this is a breaking change.
3. Change the UT accordingly.
4. Bump the version to 1.1.0.

* Reversion to 2.0.0.0 as shahabhijeet suggested

Reversion to 2.0.0.0 as shahabhijeet suggested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixwa @shahabhijeet @msftclas