Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] rename SKUs to Skus #3682

Merged
merged 2 commits into from
Sep 13, 2017
Merged

Conversation

JasonYang-MSFT
Copy link
Member

@JasonYang-MSFT JasonYang-MSFT commented Sep 12, 2017

Description

Fixed bad names in swagger for python SDK, which affect other SDKs.
Since 7.0.0 haven't released yet, this will not break current experience for customers.

Azure/azure-rest-api-specs#1650


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add < PackageReleaseNotes > and add Release notes in .csproj. This helps in knowing what is included in the nuget package.
I would recommend to use < ![CDATA and then format your Release notes

@JasonYang-MSFT
Copy link
Member Author

Changelog added, it should be available once this pr is merged.

@@ -10,4 +10,5 @@
<PropertyGroup>
<TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
</PropertyGroup>
<PackageReleaseNotes>See https://aka.ms/asdotnetsdkchangelog for release notes.</PackageReleaseNotes>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property has to be part of a propertygroup

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@shahabhijeet shahabhijeet merged commit 198930f into Azure:psSdkJson6 Sep 13, 2017
JasonYang-MSFT added a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
* [Storage] rename SKUs to Skus

* [Storage] added changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants