-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] rename SKUs to Skus #3682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add < PackageReleaseNotes > and add Release notes in .csproj. This helps in knowing what is included in the nuget package.
I would recommend to use < ![CDATA and then format your Release notes
Changelog added, it should be available once this pr is merged. |
@@ -10,4 +10,5 @@ | |||
<PropertyGroup> | |||
<TargetFrameworks>net452;netstandard1.4</TargetFrameworks> | |||
</PropertyGroup> | |||
<PackageReleaseNotes>See https://aka.ms/asdotnetsdkchangelog for release notes.</PackageReleaseNotes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property has to be part of a propertygroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
8318703
to
400e27f
Compare
* [Storage] rename SKUs to Skus * [Storage] added changelog
Description
Fixed bad names in swagger for python SDK, which affect other SDKs.
Since 7.0.0 haven't released yet, this will not break current experience for customers.
Azure/azure-rest-api-specs#1650
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.