Skip to content

Commit

Permalink
[Storage] rename SKUs to Skus (#3682)
Browse files Browse the repository at this point in the history
* [Storage] rename SKUs to Skus

* [Storage] added changelog
  • Loading branch information
JasonYang-MSFT authored and shahabhijeet committed Sep 13, 2017
1 parent 7467c8a commit 198930f
Show file tree
Hide file tree
Showing 9 changed files with 31 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ namespace Microsoft.Azure.Management.Storage
using System.Threading.Tasks;

/// <summary>
/// SKUsOperations operations.
/// SkusOperations operations.
/// </summary>
public partial interface ISKUsOperations
public partial interface ISkusOperations
{
/// <summary>
/// Lists the available SKUs supported by Microsoft.Storage for given
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ public partial interface IStorageManagementClient : System.IDisposable
IOperations Operations { get; }

/// <summary>
/// Gets the ISKUsOperations.
/// Gets the ISkusOperations.
/// </summary>
ISKUsOperations SKUs { get; }
ISkusOperations Skus { get; }

/// <summary>
/// Gets the IStorageAccountsOperations.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,20 @@ namespace Microsoft.Azure.Management.Storage
using System.Threading.Tasks;

/// <summary>
/// SKUsOperations operations.
/// SkusOperations operations.
/// </summary>
internal partial class SKUsOperations : IServiceOperations<StorageManagementClient>, ISKUsOperations
internal partial class SkusOperations : IServiceOperations<StorageManagementClient>, ISkusOperations
{
/// <summary>
/// Initializes a new instance of the SKUsOperations class.
/// Initializes a new instance of the SkusOperations class.
/// </summary>
/// <param name='client'>
/// Reference to the service client.
/// </param>
/// <exception cref="System.ArgumentNullException">
/// Thrown when a required parameter is null
/// </exception>
internal SKUsOperations(StorageManagementClient client)
internal SkusOperations(StorageManagementClient client)
{
if (client == null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ namespace Microsoft.Azure.Management.Storage
using System.Threading.Tasks;

/// <summary>
/// Extension methods for SKUsOperations.
/// Extension methods for SkusOperations.
/// </summary>
public static partial class SKUsOperationsExtensions
public static partial class SkusOperationsExtensions
{
/// <summary>
/// Lists the available SKUs supported by Microsoft.Storage for given
Expand All @@ -30,7 +30,7 @@ public static partial class SKUsOperationsExtensions
/// <param name='operations'>
/// The operations group for this extension method.
/// </param>
public static IEnumerable<Sku> List(this ISKUsOperations operations)
public static IEnumerable<Sku> List(this ISkusOperations operations)
{
return operations.ListAsync().GetAwaiter().GetResult();
}
Expand All @@ -45,7 +45,7 @@ public static IEnumerable<Sku> List(this ISKUsOperations operations)
/// <param name='cancellationToken'>
/// The cancellation token.
/// </param>
public static async Task<IEnumerable<Sku>> ListAsync(this ISKUsOperations operations, CancellationToken cancellationToken = default(CancellationToken))
public static async Task<IEnumerable<Sku>> ListAsync(this ISkusOperations operations, CancellationToken cancellationToken = default(CancellationToken))
{
using (var _result = await operations.ListWithHttpMessagesAsync(null, cancellationToken).ConfigureAwait(false))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ public partial class StorageManagementClient : ServiceClient<StorageManagementCl
public virtual IOperations Operations { get; private set; }

/// <summary>
/// Gets the ISKUsOperations.
/// Gets the ISkusOperations.
/// </summary>
public virtual ISKUsOperations SKUs { get; private set; }
public virtual ISkusOperations Skus { get; private set; }

/// <summary>
/// Gets the IStorageAccountsOperations.
Expand Down Expand Up @@ -297,7 +297,7 @@ public StorageManagementClient(System.Uri baseUri, ServiceClientCredentials cred
private void Initialize()
{
Operations = new Operations(this);
SKUs = new SKUsOperations(this);
Skus = new SkusOperations(this);
StorageAccounts = new StorageAccountsOperations(this);
Usage = new UsageOperations(this);
BaseUri = new System.Uri("https://management.azure.com");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<AssemblyName>Microsoft.Azure.Management.Storage</AssemblyName>
<Version>7.0.0-preview</Version>
<PackageTags>Microsoft Azure Storage management;Storage;Storage management</PackageTags>
<PackageReleaseNotes>See https://aka.ms/asdotnetsdkchangelog for release notes.</PackageReleaseNotes>
</PropertyGroup>
<PropertyGroup>
<TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1547,7 +1547,7 @@ public void StorageSKUListTest()
var resourcesClient = StorageManagementTestUtilities.GetResourceManagementClient(context, handler);
var storageMgmtClient = StorageManagementTestUtilities.GetStorageManagementClient(context, handler);

var skulist = storageMgmtClient.SKUs.List();
var skulist = storageMgmtClient.Skus.List();
Assert.NotNull(skulist);
Assert.Equal(@"storageAccounts", skulist.ElementAt(0).ResourceType);
Assert.NotNull(skulist.ElementAt(0).Name);
Expand Down
12 changes: 12 additions & 0 deletions src/SDKs/Storage/changelog.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
## Microsoft.Azure.Management.Storage release notes

### Changes in 7.0.0-preview

**Breaking changes**

- When updating storage virtual networks, NetworkRuleSet is used instead of NetworkAcl.

**Notes**

- When updating storage virtual networks, virtualNetworkResourceId is limited to be resource ID of a subnet.
- Added Skus.list() operation, which could list all the available skus for the subscription.
4 changes: 2 additions & 2 deletions src/SDKs/_metadata/storage_resource-manager.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
2017-08-31 08:01:39 UTC
2017-09-12 04:04:03 UTC

1) azure-rest-api-specs repository information
GitHub user: Azure
Branch: current
Commit: 21a810b65e7faed64040acf6cb0435ced80e6005
Commit: b3f4823378bab4812792ad0b90da6e8a8385a2f1

2) AutoRest information
Requested version: latest
Expand Down

0 comments on commit 198930f

Please sign in to comment.