Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASR Event and Health Changes #3663

Merged
merged 7 commits into from
Sep 11, 2017
Merged

ASR Event and Health Changes #3663

merged 7 commits into from
Sep 11, 2017

Conversation

viverm
Copy link
Contributor

@viverm viverm commented Sep 6, 2017 •
edited
Loading

Description

Azure site recovery changes for Health events .

Autorest touched many files . added < 1.2.2.0> and changed indentation of comments.

Added test for event ,health api and migratetoAad Api.

Shorten the path of test json and reorganized them to hit 240 character limit.

Increased the version in csproj and AssemblyInfo.cs

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@msftclas
Copy link

msftclas commented Sep 6, 2017

@viverm,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

shahabhijeet
shahabhijeet suggested changes Sep 7, 2017
View reviewed changes
...overyServices.SiteRecovery/Management.RecoveryServices.SiteRecovery/Generated/IOperations.cs Outdated
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Code generated by Microsoft (R) AutoRest Code Generator 1.2.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viverm you are not using the latest autorest. We no longer have this feature in the latest autorest.
If you use the latest, It will not touch all these files anymore.

@viverm
Copy link
Contributor Author

viverm commented Sep 8, 2017

Changes Taken

@viverm viverm closed this Sep 8, 2017
@viverm viverm reopened this Sep 8, 2017
@msftclas
Copy link

msftclas commented Sep 8, 2017

@viverm,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@viverm
Copy link
Contributor Author

viverm commented Sep 8, 2017 via email

@shahabhijeet shahabhijeet merged commit a907adb into Azure:psSdkJson6 Sep 11, 2017
JasonYang-MSFT pushed a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
@viverm @JasonYang-MSFT
ASR Event and Health Changes (Azure#3663)
75340cc 
* test changes and autogenerated

* indentation

* Bumbing up assembly Version

* Licence Header MICROSOFT_MIT_NO_VERSION

* SiteRecovery  Packate Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viverm @msftclas @shahabhijeet