Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADLS] Account APIs object refactor and couple of bugfixes #4046

Merged
merged 11 commits into from
Feb 10, 2018
Merged

[ADLS] Account APIs object refactor and couple of bugfixes #4046

merged 11 commits into from
Feb 10, 2018

Conversation

ro-joowan
Copy link
Contributor

@ro-joowan ro-joowan commented Feb 5, 2018 •
edited
Loading

Swagger PR Links

Changes in 2.4.0-preview

Breaking changes

  • The Account operations object has been changed from Account to Accounts
    • E.g., Account.Get(...) to Accounts.Get(...)
  • When creating or updating resources (accounts, firewall rules, etc.), explicit parameter objects are now required:
    • Account creation:
      • DataLakeStoreAccount to CreateDataLakeStoreAccountParameters
        • List of FirewallRule to CreateFirewallRuleWithAccountParameters
        • List of TrustedIdProvider to CreateTrustedIdProviderWithAccountParameters
    • Account update:
      • DataLakeStoreUpdateParameters to UpdateDataLakeStoreParameters
        • List of FirewallRule to UpdateFirewallRuleWithAccountParameters
        • List of TrustedIdProvider to UpdateTrustedIdProviderWithAccountParameters
    • Firewall rule creation and update:
      • FirewallRule to CreateOrUpdateFirewallRuleParameters
      • FirewallRule to UpdateFirewallRuleParameters
    • Trusted identity provider creation and update:
      • TrustedIdProvider to CreateOrUpdateTrustedIdProviderParameters
      • TrustedIdProvider to UpdateTrustedIdProviderParameters
  • Bugfix: Removed the childrenNum field from FileStatusProperties because it was not supported
  • Bugfix: Changed the data type of the permission field of AclStatus from int to string

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@ro-joowan
[CODE GEN] ADLS
2f329c0 
* Removed ErrorDetails.cs -- it was unused
* Account to Accounts for operations
* Explicit parameter objects for creation and update
@ro-joowan
[CODE GEN] Metadata
d81550f
@ro-joowan
Fixing custom code for file rename
b81c40b
@ro-joowan
Updating tests
2adefe8 
* Account refactor
* Permission field of AclStatus from int to string
@ro-joowan
Updating tests
3235f95
@ro-joowan
Updating SessionRecords
1366e56
@ro-joowan
[VERSION] 2.3.3-preview to 2.4.0-preview
a856639
@ro-joowan
[CHANGELOG] Update
f5a8ba9
@ro-joowan ro-joowan mentioned this pull request Feb 5, 2018
Closed
shahabhijeet
shahabhijeet suggested changes Feb 7, 2018
View reviewed changes
src/SDKs/_metadata/datalake-store_resource-manager.txt Outdated
Branch: current
Commit: db22f73d75fba57c9f1dcbd118bd1337ade842cf
GitHub user: ro-joowan
Branch: revert-path-parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be generated from master branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet Done. I also updated the metadata files for ADLA -- the PR that you already merged: #4043

@ro-joowan ro-joowan force-pushed the adls-account-refactor branch from e8114f7 to 790e322 Compare February 7, 2018 22:33
@ro-joowan
Copy link
Contributor Author

@shahabhijeet The last commit was to resolve merge conflicts

@ro-joowan
Copy link
Contributor Author

@shahabhijeet Ping -- I don't think the build error is coming from my changes

@shahabhijeet shahabhijeet merged commit 5d865e5 into Azure:psSdkJson6 Feb 10, 2018
@ro-joowan ro-joowan deleted the adls-account-refactor branch February 11, 2018 06:14
This was referenced Aug 19, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ro-joowan @shahabhijeet