[ADLA] Account APIs object refactor and adding paging extension to Catalog ACL APIs

[ro-joowan]

Swagger PR Links

• [ADLA - ADLS] - Revert path parameters azure-rest-api-specs#2417
• [ADLA - ADLS] - Account APIs object refactor azure-rest-api-specs#2391
• [ADLA - ADLS] - Adding pageable extension for Catalog ACL APIs and removing childrenNum property azure-rest-api-specs#2353

Changes in 3.3.0-preview

Breaking changes

• The Account operations object has been changed from Account to Accounts
  • E.g., Account.Get(...) to Accounts.Get(...)
• When creating or updating resources (accounts, compute policies, etc.), explicit parameter objects are now required:
  • Account creation:
    • DataLakeAnalyticsAccount to CreateDataLakeAnalyticsAccountParameters
      • List of DataLakeStoreInfo to AddDataLakeStoreWithAccountParameters
      • List of StorageAccountInfo to AddStorageAccountWithAccountParameters
      • List of FirewallRule to CreateFirewallRuleWithAccountParameters
      • List of ComputePolicy to CreateComputePolicyWithAccountParameters
  • Account update:
    • DataLakeAnalyticsUpdateParameters to UpdateDataLakeAnalyticsParameters
      • List of DataLakeStoreInfo to UpdateDataLakeStoreWithAccountParameters
      • List of StorageAccountInfo to UpdateStorageAccountWithAccountParameters
      • List of FirewallRule to UpdateFirewallRuleWithAccountParameters
      • List of ComputePolicy to UpdateComputePolicyWithAccountParameters
  • Data Lake Store account addition:
    • DataLakeStoreAccountInfo to AddDataLakeStoreParameters
  • Storage account addition and update:
    • StorageAccountInfo to AddStorageAccountParameters
    • StorageAccountInfo to UpdateStorageAccountParameters
  • Compute policy creation and update:
    • ComputePolicy to CreateOrUpdateComputePolicyParameters
    • ComputePolicy to UpdateComputePolicyParameters
  • Firewall rule creation and update:
    • FirewallRule to CreateOrUpdateFirewallRuleParameters
    • FirewallRule to UpdateFirewallRuleParameters
• When retrieving resources, all the properties are now read-only and the following object names have been changed:
  • Changed DataLakeStoreAccountInfo to DataLakeStoreAccountInformation
  • Changed StorageAccountInfo to StorageAccountInformation
• Changed the ODataQuery parameter type from JobInformation to JobInformationBasic for the Job_List API
• Changed the ODataQuery parameter type from DataLakeStoreAccountInfo to DataLakeStoreAccountInformation for the DataLakeStoreAccounts_ListByAccount API
• Changed the ODataQuery parameter type from StorageAccountInfo to StorageAccountInformation for the StorageAccounts_ListByAccount API
• Changed the return type from AclList to IPage<Acl> for these APIs:
  • Catalog_ListAclsByDatabase
  • Catalog_ListAcls

Description

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• Please add REST spec PR link to the SDK PR
• I have read the contribution guidelines.
• The pull request does not introduce breaking changes.

General Guidelines

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

SDK Generation Guidelines

• If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
• The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
• The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

[ro-joowan]

@shahabhijeet I'm not sure why Travis is running into issues trying to find the ComputePolicyCRUDTest session record. I updated this session record and it is in one of my commits, "Updating SessionRecords."

Error Message:
 System.ArgumentException : Unable to find recorded mock file '/home/travis/build/Azure/azure-sdk-for-net/src/SDKs/DataLake.Analytics/DataLakeAnalytics.Tests/bin/Debug/netcoreapp1.1/SessionRecords/DataLakeAnalytics.Tests.AccountOperationTests/ComputePolicyCRUDTest.json'.
Parameter name: callerIdentity
Stack Trace:
   at Microsoft.Azure.Test.HttpRecorder.HttpMockServer.Initialize(String callerIdentity, String testIdentity, HttpRecorderMode mode)
   at Microsoft.Rest.ClientRuntime.Azure.TestFramework.MockContext.Start(String className, String methodName)
   at DataLakeAnalytics.Tests.AccountOperationTests.ComputePolicyCRUDTest() in /home/travis/build/Azure/azure-sdk-for-net/src/SDKs/DataLake.Analytics/DataLakeAnalytics.Tests/ScenarioTests/AccountOperationTests.cs:line 362
[xUnit.net 00:00:03.4998192]   Finished:    DataLakeAnalytics.Tests

[ro-joowan]

Oh wait, for some reason, it was pushed as ComputePolicyCrudTest.json instead of ComputePolicyCRUDTest.json... I tried removing the file, which is named ComputePolicyCRUDTest.json, and then putting it back in, but it doesn't record the file name change.

[ro-joowan]

Hopefully the last commit fixes the file name issue