Added customization in RecoveryServices client and updated Microsoft.Rest.ClientRuntime to 2.3.10 #3657
Conversation
…Rest.ClientRuntime to 2.3.10
|
@sonathan, |
| @@ -11,6 +11,9 @@ | |||
| <PropertyGroup> | |||
| <TargetFrameworks>net452;netstandard1.4</TargetFrameworks> | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
| <PackageReference Update="Microsoft.Rest.ClientRuntime" Version="2.3.10" /> | |||
There was a problem hiding this comment.
@sonathan this is not needed.
We control the common packages when we have tested and ready to move to a new version of clientruntime throughout the repo.
So when the new version is out and ready to be consumed, this change will be done for the entire repo.
So please revert this change.
If we allow this change, controlling ClientRuntime version across repo will be fragmented and not manageable.
There was a problem hiding this comment.
@shahabhijeet Thank-you for letting me know of this. I'll update this in next commit.
| @@ -39,9 +39,14 @@ public RecoveryServicesClient(System.Uri baseUri, ServiceClientCredentials crede | |||
| DisableDispose = disableDispose; | |||
| } | |||
|
|
|||
| public void SetHttpClient(HttpClient client) | |||
There was a problem hiding this comment.
FYI
@sonathan the new version 2.3.9 has an overload that will allow you to control disposing of the provided client
…Rest.ClientRuntime to 2.3.10 (Azure#3657) * Added customization on RecoveryServices client and updated Microsoft.Rest.ClientRuntime to 2.3.10 * Reverting Microsoft.Rest.ClientRuntime to 2.3.8 * Removing ClientRuntime Version specification
Following items in this PR:
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.