Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Search] Merge 4.x preview code to psSdkJson6 branch and bump version #4062

Merged
merged 12 commits into from
Feb 10, 2018

Conversation

brjohnstmsft
Copy link
Member

@brjohnstmsft brjohnstmsft commented Feb 9, 2018

There is a dedicated branch for the preview versions of the Azure Search data plane SDK (currently search-4x-preview-vs17). This PR merges the latest contents of that branch into psSdkJson6 in preparation to cut a new GA SDK version. There are no functional changes here that aren't already in the preview branch.

FYI @Yahnoosh @mhko @shahabhijeet @updixit

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

I tried rebasing the search-4x-preview branch to vs17Dev, but the results were
very messy, so instead this is just a squash-merge of all the changes. This
should differ from search-4x-preview only in the project files and some minor
test changes to account for behavioral changes in the latest version of
ClientRuntime.
Search SDK: Upgrading 4x-preview to vs17 and netcore
…ure#3236)

* Renaming Management.Search to Microsoft.Azure.Management.Search

The package and assembly names were accidentally changed during the VS2017
migration. This fixes it.

* Search SDK: Updating Build-SearchPackages script
…ch-preview

Merge vs17Dev to search-4x-preview-vs17
…earch-preview

[Azure Search] Merge psSdkJson6 to search-4x-preview-vs17 branch
This new version includes some minor bug fixes that just shipped in the 3.0.5
GA SDK.
@shahabhijeet shahabhijeet merged commit 787a683 into Azure:psSdkJson6 Feb 10, 2018
@brjohnstmsft brjohnstmsft deleted the merge-search-preview branch February 10, 2018 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants