Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cognitive Services] Makes Id/Name/Type fields of CognitiveServicesAccount readonly #3633

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

felixwa
Copy link
Contributor

@felixwa felixwa commented Aug 29, 2017

Makes Id/Name/Type fields readonly by making set private.

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Makes Id/Name/Type fields readonly by making set private.
@felixwa
Copy link
Contributor Author

felixwa commented Aug 29, 2017

Note: I did not update AssemblyInfo.cs nor *.csproj because we have not released 2.0.0 version and this change is in scope of 2.0.0.

@felixwa
Copy link
Contributor Author

felixwa commented Aug 29, 2017

Consequences of Azure/azure-rest-api-specs#1589

@shahabhijeet shahabhijeet merged commit fbfa5d4 into Azure:psSdkJson6 Aug 29, 2017
JasonYang-MSFT pushed a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
Makes Id/Name/Type fields readonly by making set private.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants