[ADLA] - [BUGFIX] - Adding an innerError field to the JobInnerError object recursively #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There is no functional change in this commit * This change is purely for refactoring related to Ben's refactoring changes (which has already been accepted): Azure#1429 * Reordering fields in the example files to match with Ben's refactoring changes * Other minor changes or moving code around
There can be more levels of the innerError field in an JobInnerError object. There is currently only one level of nesting or innerError. Practically, however, the service returns up to two levels. Thus we made the change below: Currently we have: * JobErrorDetails * JobInnerError Now we have: * JobErrorDetails * JobInnerError * JobInnerSecond * JobInnerThird
* Getting rid of JobInnerErrorSecond and JobInnerErrorThird in place of a recursive definition
* In this already-merged PR (Azure#1429), Ben made some object-refactoring changes - one of them being to make all the fields in USqlJobProperties read-only as a good design decision. However, by making the fields statistics and debugData read-only, this caused some conflicts in the Powershell code. We need to pan out the design more carefully for these two fields with respect to their associated APIs ("/Jobs/{jobIdentity}/GetDebugDataPath" for the debugData field and "/Jobs/{jobIdentity}/GetStatistics" for the statistics field) before making them read-only. If I do not make the change proposed here, I would have to create two new cmdlets: one for getting the JobDataPath object and another for getting the JobStatistics object, which we do not want to do until we have a better understanding of their designs as a whole. Hence, the reverting change proposed here.
|
@ro-joowan, |
ro-joowan
changed the title
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues Send feedback and make AutoRest Linter Azure Bot smarter day by day! Thanks for your co-operation. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues Send feedback and make AutoRest Linter Azure Bot smarter day by day! Thanks for your co-operation. |
veronicagg
suggested changes
Sep 5, 2017
There was a problem hiding this comment.
@ro-joowan just one question, have you generated private code with AutoRest and made sure it looks the way you want? and that at least on the .Net SDK side the code works properly with this change?
|
@veronicagg, Yes I generated the private code and another team member made sure that it works with the .NET SDK |
veronicagg
approved these changes
Sep 5, 2017
|
No modification for AutorestCI/azure-sdk-for-node |
|
No modification for AutorestCI/azure-sdk-for-ruby |
ro-joowan
added a commit
to ro-joowan/azure-sdk-for-net
that referenced
this pull request
Sep 6, 2017
* Based on this PR: Azure/azure-rest-api-specs#1627 * We are essentially adding one more property to the JobInnerError object (recursively) in order to capture the additional error information that's returned by the service * This added property has been tested successfully by a team member
8 tasks
ro-joowan
added a commit
to ro-joowan/azure-rest-api-specs
that referenced
this pull request
Sep 6, 2017
…09-01-preview API version Based on this merged PR: Azure#1627
shahabhijeet
pushed a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
Sep 13, 2017
* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1) * [CODE REFACTOR] - Removing flaky test * Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however. * [DOC] - Updating the changelog to describe 3.1.1-preview * [CODE REFACTOR] - Skipping flaky test * Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now * [BUG FIX] - Making JobInnerError object recursively defined * Based on this PR: Azure/azure-rest-api-specs#1627 * We are essentially adding one more property to the JobInnerError object (recursively) in order to capture the additional error information that's returned by the service * This added property has been tested successfully by a team member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be more levels of the innerError field in a JobInnerError object. There is currently only one level of nesting of innerError. Practically, however, the service returns up to two levels. Theoretically, this nesting can go on forever. Hence, the recursive definition.
I made the change below:
Before:
After:
JobErrorDetails
I passed on a private build to the IDE team for testing. They did not run into any issues with the recursive definition.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger