Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[key vault] improve python readme and add multiapi client generation #9870

Merged
merged 11 commits into from
Jan 11, 2021
Merged

[key vault] improve python readme and add multiapi client generation #9870

merged 11 commits into from
Jan 11, 2021

Conversation

iscai-msft
Copy link
Contributor

Removes unnecessary python tags, and adds multiapiscript support for latest autorest to generate a multiapi client

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 17, 2020 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020 •
edited
Loading

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020 •
edited
Loading

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020 •
edited
Loading

azure-sdk-for-js

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020 •
edited
Loading

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020 •
edited
Loading

azure-sdk-for-net

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020 •
edited
Loading

azure-sdk-for-python

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020 •
edited
Loading

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020 •
edited
Loading

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
6511824 
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (22 commits)
  Update DeletionRecovery Level (Azure#9895)
  Updating operations API to enable metrics via public metrics REST API. (Azure#9918)
  Xynoclafe/2020 06 version (Azure#9888)
  update java md (Azure#9923)
  Compute 2020-06-01 API version (Azure#9167)
  Merge Dev containerservice microsoft.container service 2020 06 01 (Azure#9914)
  new Batch Document Translation API Preview 1.0 (Azure#9218)
  1. Add a property as required (Azure#9899)
  Operational insights delete wrong lines data export (Azure#9849)
  [SRP]Adding allowBlobPublicAccess and minimumTlsVersion property for June19 and April19 (Azure#9831)
  [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 (Azure#9838)
  add Java to AVS (Azure#9855)
  LaMigrationDate (Azure#9882)
  change vmware client name to AVSClient (Azure#9863)
  Fix typo in common private links definition for actionsRequired (Azure#9727)
  Microsoft.Support RP documentation updates (Azure#9880)
  BUG FIX: Fixed HopLink properties: context should be a dictionary, uint32 from… (Azure#9868)
  Update ci-fix.md (Azure#9881)
  Update Attestation control plane swagger to include 2 new defaultprovider API (Azure#9819)
  update java readme digitaltwins (Azure#9878)
  ...
@iscai-msft
temp
a5690ed
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
ce3f34f 
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (62 commits)
  fixed track2 generation (Azure#9848)
  Update description for requireGuestProvisionSignal. (Azure#9962)
  Inherent Tracked Resource and Proxy Resource from common types (Azure#9866)
  Update pull_request_assignment.yml (Azure#10005)
  Support encryption in transit feature: Add a property when creating a cluster (Azure#9894)
  updated confluent readme for input files & removed phone number property (Azure#9835)
  Update compute readme.python.md (Azure#9999)
  [Hub Generated] Review request for Microsoft.Billing to add version preview/2019-10-01-preview (Azure#9815)
  Fixed the bad output-folder (Azure#9992)
  Add preview APIs for deploying Azure machine learning services (Azure#9592)
  Rename vmware to avs in go SDK (Azure#9903)
  Add api-version 2020-06-01 of compute for go SDK (Azure#9983)
  Added 2020-06-01 API version for Microsoft.AppConfiguration. (Azure#9976)
  separated different error responses (Azure#8881)
  PersonalDesktopAssignmentType optional (Azure#9988)
  Feature/alshulma/update stable version (Azure#8884)
  update error code to use PascalCase to be syned with the library (Azure#8329)
  CosmosDB - Changes for adding PITR workflow APIs (Azure#9897)
  update the lva version and few C# autorest parameters (Azure#9990)
  add cli codegen readme files (Azure#9980)
  ...
@iscai-msft
temp
9e93178
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
721a880 
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (154 commits)
  Key Vault 7.1-preview to stable (GA) (Azure#10239)
  Fix data plane cosmosdb (Azure#10277)
  Fix example request for expanding policyEvaluationDetails (Azure#10203)
  Databricks Swagger Changes for Double Encryption (Azure#9941)
  add column delimiter for SAP Table/open hub (Azure#10269)
  add doc for typescript md (Azure#10187)
  Fix sfrp 2020-01-01-preview (Azure#10268)
  [Datafactory]Add cloudType and snapshot to ADF public swagger (Azure#10235)
  Migrate TaskRun to ProxyResource. (Azure#9953)
  [Datashare]Add sorting query parameters (Azure#10209)
  [Hub Generated] Review request for Microsoft.Insights to add version preview/2018-06-17-preview (Azure#10173)
  Update dataController onPremise property (Azure#10263)
  Changed the Client description to include Gen2 (Azure#10178)
  Managed Clusters Generate SDK (Azure#10247)
  Dev monitor microsoft.insights 2020 05 01 preview (Azure#10101)
  Add Location property to ExportPipeline and ImportPipeline (Azure#10177)
  Add enableAutomaticUpgrade property to VMExtensions for VMs and VMSS (Azure#10134)
  Add a new api and add 2020-02-02-preview versions (Azure#9710)
  Adding AML Workspace ID Property (Azure#10073)
  Add missing nullable attributes (Azure#10245)
  ...
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
7d22d79 
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (29 commits)
  Add preAttack tactic to swagger (Azure#10332)
  Add Url Signing action definition (Azure#10326)
  [Synapse] Support long running operation and add subclass of Activity in artifact (Azure#10270)
  Add native blob soft delete (Azure#10308)
  Fix Microsoft.Resources naming issue (Azure#10318)
  Notebooks swagger spec (Azure#9841)
  Add network profile in Spring payload. (Azure#10313)
  Fix output-folder for go SDK in timeseriesinsight (Azure#10300)
  Alias Put Subscription API (Azure#10205)
  resource-resource-2019-03-01-python-config (Azure#10314)
  New Api version 2020-06-15- fixing certificate put/get issues with ARM  (Azure#10251)
  [DataFactory] Support source sink level staging (Azure#10290)
  Added swagger files for PostgreSQL Flexible Server preview (Azure#10020)
  [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview (Azure#10302)
  Adding Untracked Public Maintenance Config Resource Type (Azure#10281)
  add assignment resource id to the schema (Azure#10309)
  [datashare] sort api's and definitions (Azure#10273)
  Update readme.md all-api-versions tags (Azure#10296)
  Documentation updated (Azure#10283)
  [CosmosDB] Migration support of existing containers/databases to autoscale (Azure#9258)
  ...
@iscai-msft
kv changes
986767e
@jhendrixMSFT
Copy link
Member

@iscai-msft is this PR still required?

@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
edef031 
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (364 commits)
  Update pull_request_assignment.yml (Azure#11026)
  [Ready For Review] a new version with changes on compute instance/vm sizes (Azure#10542)
  correct the description (Azure#11009)
  [Data plane][Azure Cognitive Search] Add encryptionKey property to indexer, datasource and skillset metadata (Azure#10839)
  Adding reseller Id (Azure#11013)
  Update Phone Number Administration Swagger to remove unnecessary parameters, and adjust API responses. (Azure#11010)
  update all swaggers to 2020-05-01 API version (Azure#10960)
  Changed the Instance Field Description to Support Primitive Data type (Azure#10995)
  Fix the acronym casing for ACSSMS (Azure#10988)
  Update pull_request_assignment.yml (Azure#10974)
  Add sdk_customization.md (Azure#10861)
  [Hub Generated] Review request for Microsoft.DataMigration to add version preview/2018-07-15-preview (Azure#10494)
  Make version int64 (Azure#10984)
  Microsoft.Security/iotDefenderSettings (2020-08-06-preview) (Azure#10810)
  added incident alerts and incident bookmarks APIs (Azure#10806)
  add publicNetworkAccess property to datafactory (Azure#10956)
  Fix CDN matchValues and selector fields to be optional (Azure#10950)
  [Microsoft.StorageSync] Introduce 2020-09-01 API version (Azure#10836)
  strings update (Azure#10969)
  Update QnAMaker.json - response code correction (Azure#10828)
  ...
@iscai-msft
Copy link
Contributor Author

@chlowell @mccoyp I'm good to merge this PR if you guys want it

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 9870 in repo Azure/azure-rest-api-specs

@iscai-msft iscai-msft requested a review from mccoyp October 5, 2020 15:13
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 5, 2020 •
edited
Loading

azure-resource-manager-schemas

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

chlowell
chlowell approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll take it. Are the multiapiscript settings up to date?

@iscai-msft
Copy link
Contributor Author

iscai-msft commented Oct 5, 2020 •
edited
Loading

@chlowell i don't have the administration package, but the rest are good. I'll go ahead and merge and you can add your admin package tag later.

EDIT: i lied, I can't merge the PR, @jhendrixMSFT do you have merge permissions?

@ghost
Copy link

ghost commented Dec 27, 2020

Hi, @iscai-msft. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@ghost ghost added the no-recent-activity label Dec 27, 2020
@jhendrixMSFT
Copy link
Member

/azp run

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 11, 2021 •
edited
Loading

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 731b282. SDK Automation 14.0.0 
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️preview/keyvault/v7.2-preview/keyvault [View full logs]  [Release SDK Changes] 
    info	[Changelog] ## New Content
info	[Changelog]
info	[Changelog] - New function `RoleDefinitionsClient.CreateOrUpdate(context.Context, string, string, string, RoleDefinitionCreateParameters) (RoleDefinition, error)`
info	[Changelog] - New function `RoleDefinitionsClient.DeleteSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `RoleDefinitionsClient.GetResponder(*http.Response) (RoleDefinition, error)`
info	[Changelog] - New function `RoleDefinitionsClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `RoleDefinitionsClient.Get(context.Context, string, string, string) (RoleDefinition, error)`
info	[Changelog] - New function `RoleDefinitionsClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `RoleDefinitionsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `RoleDefinitionsClient.Delete(context.Context, string, string, string) (RoleDefinition, error)`
info	[Changelog] - New function `RoleDefinitionsClient.DeleteResponder(*http.Response) (RoleDefinition, error)`
info	[Changelog] - New function `RoleDefinitionsClient.CreateOrUpdatePreparer(context.Context, string, string, string, RoleDefinitionCreateParameters) (*http.Request, error)`
info	[Changelog] - New function `RoleDefinitionsClient.DeletePreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `RoleDefinitionsClient.CreateOrUpdateResponder(*http.Response) (RoleDefinition, error)`
info	[Changelog] - New struct `RoleDefinitionCreateParameters`
info	[Changelog] - New field `AuthenticationTag` in struct `KeyOperationResult`
info	[Changelog] - New field `AdditionalAuthenticatedData` in struct `KeyOperationResult`
info	[Changelog] - New field `Iv` in struct `KeyOperationResult`
info	[Changelog] - New anonymous field `autorest.Response` in struct `RoleDefinition`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 16 additive change(s).
info	[Changelog]
  • ️✔️keyvault/v7.1/keyvault [View full logs]  [Release SDK Changes] 
    info	[Changelog] No exported changes
  • ️✔️keyvault/v7.0/keyvault [View full logs]  [Release SDK Changes] 
    info	[Changelog] No exported changes
  • ️✔️keyvault/2016-10-01/keyvault [View full logs]  [Release SDK Changes] 
    info	[Changelog] No exported changes
  • ️✔️keyvault/2015-06-01/keyvault [View full logs]  [Release SDK Changes] 
    info	[Changelog] No exported changes
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jhendrixMSFT jhendrixMSFT merged commit 731b282 into Azure:master Jan 11, 2021
This was referenced Jan 11, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviwil daviwil daviwil left review comments

@chlowell chlowell chlowell approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@jlichwa jlichwa Awaiting requested review from jlichwa jlichwa is a code owner

@heaths heaths Awaiting requested review from heaths heaths is a code owner

@RandalliLama RandalliLama Awaiting requested review from RandalliLama

@mccoyp mccoyp Awaiting requested review from mccoyp

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iscai-msft @azuresdkci @jhendrixMSFT @daviwil @chlowell @heaths