-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready For Review] a new version with changes on compute instance/vm sizes #10542
Conversation
Ninhu/azureml api 2020 08 01
Update vmSizes API
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
Add missing definition of last operaton for compute instance
Azure Pipelines successfully started running 1 pipeline(s). |
Fixing validation errors
Update machineLearningServices.json
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 suggestion
"$ref": "#/parameters/SubscriptionIdParameter" | ||
}, | ||
{ | ||
"$ref": "#/parameters/ComputeTypeParameter" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you already have query params not using $filter but I strongly suggest using the odata $filter syntax for any filtering params like this on collection GETs (i.e. $filter='computeType' eq 'foo' and 'whatever' eq 'bar')
Pull request contains merge conflicts. |
Pull request contains merge conflicts. |
Pull request contains merge conflicts. |
No commit pushedDate could be found for PR 10542 in repo Azure/azure-rest-api-specs |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (364 commits) Update pull_request_assignment.yml (Azure#11026) [Ready For Review] a new version with changes on compute instance/vm sizes (Azure#10542) correct the description (Azure#11009) [Data plane][Azure Cognitive Search] Add encryptionKey property to indexer, datasource and skillset metadata (Azure#10839) Adding reseller Id (Azure#11013) Update Phone Number Administration Swagger to remove unnecessary parameters, and adjust API responses. (Azure#11010) update all swaggers to 2020-05-01 API version (Azure#10960) Changed the Instance Field Description to Support Primitive Data type (Azure#10995) Fix the acronym casing for ACSSMS (Azure#10988) Update pull_request_assignment.yml (Azure#10974) Add sdk_customization.md (Azure#10861) [Hub Generated] Review request for Microsoft.DataMigration to add version preview/2018-07-15-preview (Azure#10494) Make version int64 (Azure#10984) Microsoft.Security/iotDefenderSettings (2020-08-06-preview) (Azure#10810) added incident alerts and incident bookmarks APIs (Azure#10806) add publicNetworkAccess property to datafactory (Azure#10956) Fix CDN matchValues and selector fields to be optional (Azure#10950) [Microsoft.StorageSync] Introduce 2020-09-01 API version (Azure#10836) strings update (Azure#10969) Update QnAMaker.json - response code correction (Azure#10828) ...
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.