added incident alerts and incident bookmarks APIs #10806

moranraz · 2020-09-16T07:35:28Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

AutorestCI · 2020-09-16T07:35:30Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

openapi-pipeline-app · 2020-09-16T07:35:32Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2020-09-16T07:35:33Z

Thank you for your contribution moranraz! We will review the pull request and get back to you soon.

pilor · 2020-09-21T18:44:41Z

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json

@@ -2932,6 +2932,102 @@
        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{operationalInsightsResourceProvider}/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/incidents/{incidentId}/alerts": {


Why are these 2 new APIs POST calls instead of GETs?

Alerts and Bookmarks are not a child resource of an incident (they can be independent resources, or nested under other resources as well). Therefore we couldn't create a GET endpoint nested under the incidents resource.

I see. Please rename the post actions to "listAlerts" and "listBookmarks" and make sure to map the authorization action for these to /read in your manifest. See https://armwiki.azurewebsites.net/rp_onboarding/ResourceProviderRegistration.html#authorizationactionmappings-optional

changed the names.
the authorization mapping is already done.

I am referring to the POST action name (the terminal URI segment). It should be "/listAlerts", etc...

Oh, my bad. Changing the operation ids back.
As for adding it to the URI segment, I'm not sure this is what we want. None of our other APIs have this format of "/listSomething". Please see for example the action with the operation id "Incidents_ListOfEntities". That one is also a POST action (for the same reason I mentioned above), and the format is incidents/{incidentId}/entities.

POST calls are actions, they should be a verb. Using a "list" prefix also allows them to be called from template deployments (although that isn't very useful in this scenario).

I understand. However this is a POST call for more of a technical reason, rather than a logical one. The API names were a PM requirement, so we can be aligned with the rest of our calls (just incidents/{incidentId}/entities I mentioned, which is also a POST call for the same reason).

njuCZ · 2020-09-29T08:12:07Z

/azp run

azure-pipelines · 2020-09-29T08:12:26Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2020-09-29T08:13:51Z

Azure CLI Extension Generation - Release

Installation instruction for service securityinsight [Preview Changes]
curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/azure-rest-api-specs/10806/azure-cli-extensions/securityinsight/sentinel-0.1.0-py3-none-any.whl" -o sentinel-0.1.0-py3-none-any.whl az extension add --source=sentinel-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from f892439 with merge commit c40cc1a. Azure CLI Automation 13.0.17.20200918.2

[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
[AutoRest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /Actions/get/Get all actions of alert rule.
[AutoRest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
[AutoRest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates an action of alert rule.
[AutoRest]     - name: /AlertRules/get/Get a Fusion alert rule.
[AutoRest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/get/Get a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/get/Get all alert rules.
[AutoRest]     - name: /AlertRules/get/Get an action of alert rule.
[AutoRest]     - name: /Bookmarks/put/Creates or updates a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get all bookmarks.
[AutoRest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
[AutoRest]     - name: /DataConnectors/get/Get a ASC data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MCAS data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MDATP data connector
[AutoRest]     - name: /DataConnectors/get/Get a TI data connector.
[AutoRest]     - name: /DataConnectors/get/Get all data connectors.
[AutoRest]     - name: /DataConnectors/get/Get an AAD data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AATP data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
[AutoRest]     - name: /DataConnectors/get/Get an Office365 data connector.
[AutoRest]     - name: /IncidentComments/put/Creates an incident comment.
[AutoRest]     - name: /IncidentComments/get/Get all incident comments.
[AutoRest]     - name: /IncidentComments/get/Get an incident comment.
[AutoRest]     - name: /Incidents/put/Creates or updates an incident.
[AutoRest]     - name: /Incidents/get/Get all incidents.
[AutoRest]     - name: /Incidents/get/Get an incident.
[AutoRest]     - name: /AlertRules/delete/Delete an alert rule.
[AutoRest]     - name: /AlertRules/delete/Delete an action of alert rule.
[AutoRest]     - name: /Bookmarks/delete/Delete a bookmark.
[AutoRest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
[AutoRest]     - name: /Incidents/delete/Delete an incident.
[AutoRest] --------------------------------------------------------

️✔️securityinsight [View full logs] [Release Azure CLI Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 29 Sep 2020 09:17:16 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0483:F30F:13AA31E:1798D1B:5F72FB9B","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-29T08:13:52Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-29T08:13:52Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from f892439 with merge commit c40cc1a. SDK Automation 13.0.17.20200918.2

️✔️preview/securityinsight/mgmt/2019-01-01-preview [View full logs] [Release SDK Changes]

preview.securityinsight.mgmt.2019-01-01-preview.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 29 Sep 2020 09:20:45 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0700:3EFE:29CA6A6:447B4F1:5F72FC6D","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

️✔️securityinsight/mgmt/v1.0 [View full logs] [Release SDK Changes]

securityinsight.mgmt.v1.0.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 29 Sep 2020 09:20:57 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0701:065C:16F0BDC2:1B4E66E9:5F72FC79","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-29T08:13:55Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from f892439 with merge commit c40cc1a. SDK Automation 13.0.17.20200918.2
```
[azure-mgmt-securityinsight][ChangeLog] WARNING: Failed to generate ChangeLog.
```

⚠️azure-mgmt-securityinsight [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools:Template done azure-mgmt-securityinsight
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 29 Sep 2020 09:17:41 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0780:6615:14B2786:30F0FE2:5F72FBB5","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

openapi-sdkautomation · 2020-09-29T08:13:57Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-29T08:13:57Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from f892439 with merge commit c40cc1a. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-29T08:13:58Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from f892439 with merge commit c40cc1a. SDK Automation 13.0.17.20200918.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityInsights [View full logs] [Release SDK Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 29 Sep 2020 09:19:11 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0400:549B:2B8DE36:46468B0:5F72FC0F","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-29T08:14:02Z

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from f892439 with merge commit c40cc1a. Schema Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-29T08:14:04Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (364 commits) Update pull_request_assignment.yml (Azure#11026) [Ready For Review] a new version with changes on compute instance/vm sizes (Azure#10542) correct the description (Azure#11009) [Data plane][Azure Cognitive Search] Add encryptionKey property to indexer, datasource and skillset metadata (Azure#10839) Adding reseller Id (Azure#11013) Update Phone Number Administration Swagger to remove unnecessary parameters, and adjust API responses. (Azure#11010) update all swaggers to 2020-05-01 API version (Azure#10960) Changed the Instance Field Description to Support Primitive Data type (Azure#10995) Fix the acronym casing for ACSSMS (Azure#10988) Update pull_request_assignment.yml (Azure#10974) Add sdk_customization.md (Azure#10861) [Hub Generated] Review request for Microsoft.DataMigration to add version preview/2018-07-15-preview (Azure#10494) Make version int64 (Azure#10984) Microsoft.Security/iotDefenderSettings (2020-08-06-preview) (Azure#10810) added incident alerts and incident bookmarks APIs (Azure#10806) add publicNetworkAccess property to datafactory (Azure#10956) Fix CDN matchValues and selector fields to be optional (Azure#10950) [Microsoft.StorageSync] Introduce 2020-09-01 API version (Azure#10836) strings update (Azure#10969) Update QnAMaker.json - response code correction (Azure#10828) ...

added incident alerts and incident bookmarks endpoints

000511f

openapi-assignment-bot bot assigned ruowan Sep 16, 2020

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 16, 2020

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2020

Moran Raz Mizrahi added 3 commits September 16, 2020 13:37

changed definition order

f993eb8

style changes

0d8cd77

remove labels

4e7e553

pilor self-requested a review September 21, 2020 18:43

pilor suggested changes Sep 21, 2020

View reviewed changes

pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 21, 2020

Moran Raz Mizrahi added 2 commits September 24, 2020 11:46

change operation ids

fd229fb

changing ids back

f892439

pilor approved these changes Sep 28, 2020

View reviewed changes

njuCZ approved these changes Sep 29, 2020

View reviewed changes

njuCZ merged commit c40cc1a into Azure:master Sep 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added incident alerts and incident bookmarks APIs #10806

added incident alerts and incident bookmarks APIs #10806

moranraz commented Sep 16, 2020 •

edited

Loading

AutorestCI commented Sep 16, 2020

openapi-pipeline-app bot commented Sep 16, 2020 •

edited

Loading

ghost commented Sep 16, 2020

pilor Sep 21, 2020

moranraz Sep 21, 2020

pilor Sep 23, 2020

moranraz Sep 24, 2020

pilor Sep 24, 2020

moranraz Sep 24, 2020

pilor Sep 24, 2020

moranraz Sep 26, 2020

njuCZ commented Sep 29, 2020

azure-pipelines bot commented Sep 29, 2020

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

added incident alerts and incident bookmarks APIs #10806

added incident alerts and incident bookmarks APIs #10806

Conversation

moranraz commented Sep 16, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

AutorestCI commented Sep 16, 2020

openapi-pipeline-app bot commented Sep 16, 2020 • edited Loading

[Staging] Swagger Validation Report

ghost commented Sep 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

njuCZ commented Sep 29, 2020

azure-pipelines bot commented Sep 29, 2020

openapi-sdkautomation bot commented Sep 29, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Sep 29, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Sep 29, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Sep 29, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Sep 29, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Sep 29, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Sep 29, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Sep 29, 2020 • edited Loading

azure-resource-manager-schemas - Release

openapi-sdkautomation bot commented Sep 29, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

moranraz commented Sep 16, 2020 •

edited

Loading

openapi-pipeline-app bot commented Sep 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 29, 2020 •

edited

Loading