Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HDInsight] Support encryption in transit feature: #9894

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

aim-for-better
Copy link
Member

@aim-for-better aim-for-better commented Jun 19, 2020

Support encryption in transit feature:

  • Add a property when creating a cluster

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 19, 2020

[Staging] Swagger Validation Report

BreakingChange: 4 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1041 - AddedPropertyInResponse The new version has a new property 'encryptionAtHost' in response that was not found in the old version.
New: Microsoft.HDInsight/preview/2015-03-01-preview/cluster.json#L1492:7
Old: Microsoft.HDInsight/preview/2015-03-01-preview/cluster.json#L1481:7
1041 - AddedPropertyInResponse The new version has a new property 'encryptionInTransitProperties' in response that was not found in the old version.
New: Microsoft.HDInsight/preview/2015-03-01-preview/cluster.json#L1115:7
Old: Microsoft.HDInsight/preview/2015-03-01-preview/cluster.json#L1108:7
1041 - AddedPropertyInResponse The new version has a new property 'encryptionAtHost' in response that was not found in the old version.
New: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L1492:7
Old: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L1481:7
1041 - AddedPropertyInResponse The new version has a new property 'encryptionInTransitProperties' in response that was not found in the old version.
New: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L1115:7
Old: Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json#L1108:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 0d8c9df with merge commit fb0345c. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-hdinsight [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/hDInsightManagementClient.js → ./dist/arm-hdinsight.js...
    [npmPack] created ./dist/arm-hdinsight.js in 386ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 8.3kB   esm/operations/applications.js                   
    [npmPack] npm notice 1.2kB   esm/models/applicationsMappers.js                
    [npmPack] npm notice 181.8kB dist/arm-hdinsight.js                            
    [npmPack] npm notice 61.3kB  dist/arm-hdinsight.min.js                        
    [npmPack] npm notice 19.8kB  esm/operations/clusters.js                       
    [npmPack] npm notice 1.4kB   esm/models/clustersMappers.js                    
    [npmPack] npm notice 6.1kB   esm/operations/configurations.js                 
    [npmPack] npm notice 435B    esm/models/configurationsMappers.js              
    [npmPack] npm notice 11.5kB  esm/operations/extensions.js                     
    [npmPack] npm notice 472B    esm/models/extensionsMappers.js                  
    [npmPack] npm notice 2.2kB   esm/hDInsightManagementClient.js                 
    [npmPack] npm notice 2.7kB   esm/hDInsightManagementClientContext.js          
    [npmPack] npm notice 345B    esm/models/index.js                              
    [npmPack] npm notice 644B    esm/operations/index.js                          
    [npmPack] npm notice 3.4kB   esm/operations/locations.js                      
    [npmPack] npm notice 715B    esm/models/locationsMappers.js                   
    [npmPack] npm notice 77.9kB  esm/models/mappers.js                            
    [npmPack] npm notice 2.3kB   esm/operations/operations.js                     
    [npmPack] npm notice 458B    esm/models/operationsMappers.js                  
    [npmPack] npm notice 3.1kB   esm/models/parameters.js                         
    [npmPack] npm notice 989B    rollup.config.js                                 
    [npmPack] npm notice 4.9kB   esm/operations/scriptActions.js                  
    [npmPack] npm notice 508B    esm/models/scriptActionsMappers.js               
    [npmPack] npm notice 3.9kB   esm/operations/scriptExecutionHistory.js         
    [npmPack] npm notice 532B    esm/models/scriptExecutionHistoryMappers.js      
    [npmPack] npm notice 4.6kB   esm/operations/virtualMachines.js                
    [npmPack] npm notice 423B    esm/models/virtualMachinesMappers.js             
    [npmPack] npm notice 1.7kB   package.json                                     
    [npmPack] npm notice 457B    tsconfig.json                                    
    [npmPack] npm notice 2.4kB   esm/operations/applications.d.ts.map             
    [npmPack] npm notice 4.1kB   esm/operations/applications.js.map               
    [npmPack] npm notice 653B    esm/models/applicationsMappers.d.ts.map          
    [npmPack] npm notice 666B    esm/models/applicationsMappers.js.map            
    [npmPack] npm notice 323.5kB dist/arm-hdinsight.js.map                        
    [npmPack] npm notice 51.7kB  dist/arm-hdinsight.min.js.map                    
    [npmPack] npm notice 5.3kB   esm/operations/clusters.d.ts.map                 
    [npmPack] npm notice 10.0kB  esm/operations/clusters.js.map                   
    [npmPack] npm notice 766B    esm/models/clustersMappers.d.ts.map              
    [npmPack] npm notice 779B    esm/models/clustersMappers.js.map                
    [npmPack] npm notice 1.9kB   esm/operations/configurations.d.ts.map           
    [npmPack] npm notice 3.0kB   esm/operations/configurations.js.map             
    [npmPack] npm notice 200B    esm/models/configurationsMappers.d.ts.map        
    [npmPack] npm notice 213B    esm/models/configurationsMappers.js.map          
    [npmPack] npm notice 2.7kB   esm/operations/extensions.d.ts.map               
    [npmPack] npm notice 5.3kB   esm/operations/extensions.js.map                 
    [npmPack] npm notice 215B    esm/models/extensionsMappers.d.ts.map            
    [npmPack] npm notice 228B    esm/models/extensionsMappers.js.map              
    [npmPack] npm notice 917B    esm/hDInsightManagementClient.d.ts.map           
    [npmPack] npm notice 1.2kB   esm/hDInsightManagementClient.js.map             
    [npmPack] npm notice 517B    esm/hDInsightManagementClientContext.d.ts.map    
    [npmPack] npm notice 1.4kB   esm/hDInsightManagementClientContext.js.map      
    [npmPack] npm notice 21.9kB  esm/models/index.d.ts.map                        
    [npmPack] npm notice 315B    esm/operations/index.d.ts.map                    
    [npmPack] npm notice 126B    esm/models/index.js.map                          
    [npmPack] npm notice 330B    esm/operations/index.js.map                      
    [npmPack] npm notice 1.5kB   esm/operations/locations.d.ts.map                
    [npmPack] npm notice 2.1kB   esm/operations/locations.js.map                  
    [npmPack] npm notice 370B    esm/models/locationsMappers.d.ts.map             
    [npmPack] npm notice 383B    esm/models/locationsMappers.js.map               
    [npmPack] npm notice 4.2kB   esm/models/mappers.d.ts.map                      
    [npmPack] npm notice 42.5kB  esm/models/mappers.js.map                        
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map               
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map                 
    [npmPack] npm notice 215B    esm/models/operationsMappers.d.ts.map            
    [npmPack] npm notice 228B    esm/models/operationsMappers.js.map              
    [npmPack] npm notice 778B    esm/models/parameters.d.ts.map                   
    [npmPack] npm notice 2.4kB   esm/models/parameters.js.map                     
    [npmPack] npm notice 2.2kB   esm/operations/scriptActions.d.ts.map            
    [npmPack] npm notice 2.8kB   esm/operations/scriptActions.js.map              
    [npmPack] npm notice 237B    esm/models/scriptActionsMappers.d.ts.map         
    [npmPack] npm notice 250B    esm/models/scriptActionsMappers.js.map           
    [npmPack] npm notice 1.7kB   esm/operations/scriptExecutionHistory.d.ts.map   
    [npmPack] npm notice 2.2kB   esm/operations/scriptExecutionHistory.js.map     
    [npmPack] npm notice 255B    esm/models/scriptExecutionHistoryMappers.d.ts.map
    [npmPack] npm notice 268B    esm/models/scriptExecutionHistoryMappers.js.map  
    [npmPack] npm notice 1.2kB   esm/operations/virtualMachines.d.ts.map          
    [npmPack] npm notice 2.3kB   esm/operations/virtualMachines.js.map            
    [npmPack] npm notice 199B    esm/models/virtualMachinesMappers.d.ts.map       
    [npmPack] npm notice 212B    esm/models/virtualMachinesMappers.js.map         
    [npmPack] npm notice 3.4kB   README.md                                        
    [npmPack] npm notice 6.4kB   esm/operations/applications.d.ts                 
    [npmPack] npm notice 12.1kB  src/operations/applications.ts                   
    [npmPack] npm notice 882B    esm/models/applicationsMappers.d.ts              
    [npmPack] npm notice 1.2kB   src/models/applicationsMappers.ts                
    [npmPack] npm notice 14.0kB  esm/operations/clusters.d.ts                     
    [npmPack] npm notice 27.4kB  src/operations/clusters.ts                       
    [npmPack] npm notice 1.1kB   esm/models/clustersMappers.d.ts                  

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 0d8c9df with merge commit fb0345c. SDK Automation 13.0.17.20200619.4
  • ️✔️sdk/hdinsight/mgmt-v2015_03_01_preview [View full logs]  [Release SDK Changes]
  • ⚠️sdk/hdinsight/mgmt-v2018_06_01_preview [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/Utilities.java:[17,28] package org.assertj.core.api does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/scenariotests/HDInsightManagementTestBase.java:[12,47] package com.microsoft.azure.management.keyvault does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/scenariotests/HDInsightManagementTestBase.java:[13,62] package com.microsoft.azure.management.keyvault.implementation does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/scenariotests/HDInsightManagementTestBase.java:[15,46] package com.microsoft.azure.management.storage does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/Utilities.java:[23,35] package org.assertj.core.api does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/Utilities.java:[23,1] static import only from classes and interfaces
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/Utilities.java:[151,125] package com.microsoft.azure.management.storage does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/Utilities.java:[158,125] package com.microsoft.azure.management.storage does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/Utilities.java:[180,116] package com.microsoft.azure.management.storage does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[9,36] package com.microsoft.azure.keyvault does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[10,36] package com.microsoft.azure.keyvault does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[11,43] package com.microsoft.azure.keyvault.models does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[12,45] package com.microsoft.azure.keyvault.requests does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[13,43] package com.microsoft.azure.keyvault.webkey does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[14,1] package com.microsoft.azure.management.keyvault does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[15,62] package com.microsoft.azure.management.keyvault.implementation does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[16,62] package com.microsoft.azure.management.keyvault.implementation does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[17,57] package com.microsoft.azure.management.msi.implementation does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[18,57] package com.microsoft.azure.management.msi.implementation does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[21,46] package com.microsoft.azure.management.storage does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[22,46] package com.microsoft.azure.management.storage does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[23,46] package com.microsoft.azure.management.storage does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[24,61] package com.microsoft.azure.management.storage.implementation does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[26,29] package org.assertj.core.util does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[34,53] package com.microsoft.azure.management.storage does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[34,1] static import only from classes and interfaces
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[35,35] package org.assertj.core.api does not exist
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[35,1] static import only from classes and interfaces
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/scenariotests/HDInsightManagementTestBase.java:[77,5] cannot find symbol
      [mvn]   symbol:   class StorageAccount
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.scenariotests.HDInsightManagementTestBase
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/scenariotests/HDInsightManagementTestBase.java:[82,5] cannot find symbol
      [mvn]   symbol:   class VaultInner
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.scenariotests.HDInsightManagementTestBase
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/scenariotests/HDInsightManagementTestBase.java:[156,31] cannot find symbol
      [mvn]   symbol:   class VaultInner
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.scenariotests.HDInsightManagementTestBase
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/scenariotests/HDInsightManagementTestBase.java:[156,64] cannot find symbol
      [mvn]   symbol:   class Permissions
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.scenariotests.HDInsightManagementTestBase
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/scenariotests/HDInsightManagementTestBase.java:[156,5] cannot find symbol
      [mvn]   symbol:   class VaultInner
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.scenariotests.HDInsightManagementTestBase
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[45,26] cannot find symbol
      [mvn]   symbol:   class Permissions
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[61,19] cannot find symbol
      [mvn]   symbol:   class StorageManager
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[66,19] cannot find symbol
      [mvn]   symbol:   class MSIManager
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[71,19] cannot find symbol
      [mvn]   symbol:   class KeyVaultManager
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[76,19] cannot find symbol
      [mvn]   symbol:   class KeyVaultClient
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[129,12] cannot find symbol
      [mvn]   symbol:   class StorageAccount
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[133,12] cannot find symbol
      [mvn]   symbol:   class StorageAccount
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[137,93] cannot find symbol
      [mvn]   symbol:   class Kind
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[137,12] cannot find symbol
      [mvn]   symbol:   class StorageAccount
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[149,48] cannot find symbol
      [mvn]   symbol:   class StorageAccountSkuType
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[151,48] cannot find symbol
      [mvn]   symbol:   class Kind
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[147,12] cannot find symbol
      [mvn]   symbol:   class StorageAccount
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[178,31] cannot find symbol
      [mvn]   symbol:   class StorageAccount
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[190,12] cannot find symbol
      [mvn]   symbol:   class IdentityInner
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[194,12] cannot find symbol
      [mvn]   symbol:   class IdentityInner
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[203,12] cannot find symbol
      [mvn]   symbol:   class VaultInner
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[217,35] cannot find symbol
      [mvn]   symbol:   class SkuName
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[218,35] cannot find symbol
      [mvn]   symbol:   class Permissions
      [mvn]   location: class com.microsoft.azure.management.hdinsight.v2018_06_01_preview.utilities.HDInsightTestResourceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/hdinsight/mgmt-v2018_06_01_preview/src/test/java/com/microsoft/azure/management/hdinsight/v2018_06_01_preview/utilities/HDInsightTestResourceManager.java:[216,12] cannot find symbol
      [mvn]   symbol:   class VaultInner

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 19, 2020

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 0d8c9df with merge commit fb0345c. SDK Automation 13.0.17.20200619.4
    • ️✔️azure-mgmt-hdinsight [View full logs]  [Release SDK Changes]
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-hdinsight
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-hdinsight
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 4.106% size of original (original: 46983 chars, delta: 1929 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model ClusterCreateProperties has a new parameter network_settings
      [ChangeLog]   - Model ClusterCreateProperties has a new parameter encryption_in_transit_properties
      [ChangeLog]   - Model DiskEncryptionProperties has a new parameter encryption_at_host
      [ChangeLog]   - Model ClusterGetProperties has a new parameter network_settings
      [ChangeLog]   - Model ClusterGetProperties has a new parameter encryption_in_transit_properties

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @chiragg4u
    Copy link
    Contributor

    Please go through the checklist added as part of the review and mark them completed.

    @aim-for-better
    Copy link
    Member Author

    Please go through the checklist added as part of the review and mark them completed.

    Done

    @chiragg4u
    Copy link
    Contributor

    As identified in the automated checks there are breaking changes, Please follow Azure Breaking changes approval request form as defined @ Breaking Change Process

    Also I see other issues with the swaggers
    Item #1: Version 2015-03-01-preview is over 12 months old. It needs to be retired. Please provide your plan to retire this API version.
    Item #2: You have a “stable preview” – this is not allowed. It’s either preview or GA. Please provide your plan to correct this error.
    Item #3: You do not have a GA released version of the API, yet your service is GA. Please provide your plan to correct this.

    @aim-for-better aim-for-better mentioned this pull request Jun 22, 2020
    4 tasks
    @ravbhatnagar
    Copy link
    Contributor

    Removing the WaitForARMFeedback label. Adding new properties dont require ARM sign off going forward.

    @ravbhatnagar ravbhatnagar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 23, 2020
    @leniatgh leniatgh added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Jun 24, 2020
    @aim-for-better
    Copy link
    Member Author

    aim-for-better commented Jun 28, 2020

    As identified in the automated checks there are breaking changes, Please follow Azure Breaking changes approval request form as defined @ Breaking Change Process

    Also I see other issues with the swaggers
    Item #1: Version 2015-03-01-preview is over 12 months old. It needs to be retired. Please provide your plan to retire this API version.
    Item #2: You have a “stable preview” – this is not allowed. It’s either preview or GA. Please provide your plan to correct this error.
    Item #3: You do not have a GA released version of the API, yet your service is GA. Please provide your plan to correct this.

    We have sent related email about this breaking change to your team. @deshriva will follow the issue you proposed.
    The latest news is that our service is tagged as preview, this is not a breaking change now.

    @aim-for-better aim-for-better force-pushed the SupportEncryptionInTransit branch from e0eabc8 to 0d8c9df Compare June 29, 2020 07:58
    @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 29, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 29, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @leniatgh leniatgh removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 29, 2020
    @leniatgh
    Copy link
    Contributor

    @aim-for-better Although it's a preview version, but it's been over several years old. So it may break existing users. pls clarify if it's really necessary to introduce the breaking change.

    @aim-for-better
    Copy link
    Member Author

    @aim-for-better Although it's a preview version, but it's been over several years old. So it may break existing users. pls clarify if it's really necessary to introduce the breaking change.

    There is no impact in customers, for create api: this property is optional, for get api, this property won't be returned if the cluster doesn't specify the property when creating cluster.

    @aim-for-better
    Copy link
    Member Author

    @aim-for-better Although it's a preview version, but it's been over several years old. So it may break existing users. pls clarify if it's really necessary to introduce the breaking change.

    There is no impact in customers, for create api: this property is optional, for get api, this property won't be returned if the cluster doesn't specify the property when creating cluster.

    @leniatgh leniatgh added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Jun 30, 2020
    @akning-ms
    Copy link
    Contributor

    Hi @aim-for-better, Can you confirm it is stable version for Microsoft.HDInsight/stable/2018-06-01-preview? as it is in stable folder.
    I remember we discussed this before. it will cause lots of confuse. you may need a plan to fix it. and also if it is a stable. it will be a breaking change which need API review board approval.

    @aim-for-better
    Copy link
    Member Author

    Hi @aim-for-better, Can you confirm it is stable version for Microsoft.HDInsight/stable/2018-06-01-preview? as it is in stable folder.
    I remember we discussed this before. it will cause lots of confuse. you may need a plan to fix it. and also if it is a stable. it will be a breaking change which need API review board approval.

    Hi @akning-ms ,I have sent you an email about this. I am so sorry about the confusing api verison.

    @akning-ms akning-ms merged commit fb0345c into Azure:master Jul 1, 2020
    iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
    …into fix_kv_python_readme
    
    * 'master' of https://github.com/Azure/azure-rest-api-specs: (62 commits)
      fixed track2 generation (Azure#9848)
      Update description for requireGuestProvisionSignal. (Azure#9962)
      Inherent Tracked Resource and Proxy Resource from common types (Azure#9866)
      Update pull_request_assignment.yml (Azure#10005)
      Support encryption in transit feature: Add a property when creating a cluster (Azure#9894)
      updated confluent readme for input files & removed phone number property (Azure#9835)
      Update compute readme.python.md (Azure#9999)
      [Hub Generated] Review request for Microsoft.Billing to add version preview/2019-10-01-preview (Azure#9815)
      Fixed the bad output-folder (Azure#9992)
      Add preview APIs for deploying Azure machine learning services (Azure#9592)
      Rename vmware to avs in go SDK (Azure#9903)
      Add api-version 2020-06-01 of compute for go SDK (Azure#9983)
      Added 2020-06-01 API version for Microsoft.AppConfiguration. (Azure#9976)
      separated different error responses (Azure#8881)
      PersonalDesktopAssignmentType optional (Azure#9988)
      Feature/alshulma/update stable version (Azure#8884)
      update error code to use PascalCase to be syned with the library (Azure#8329)
      CosmosDB - Changes for adding PITR workflow APIs (Azure#9897)
      update the lva version and few C# autorest parameters (Azure#9990)
      add cli codegen readme files (Azure#9980)
      ...
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants