-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preview APIs for deploying Azure machine learning services #9592
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-trenton
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
Can one of the admins verify this patch? |
Pull request contains merge conflicts. |
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
...er/Microsoft.MachineLearningServices/preview/2020-05-01-preview/machineLearningServices.json
Show resolved
Hide resolved
Hi @keerthiadu could you please fix the CI model validation? |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that we are defining a lot of models without using inheritance. Is it applicable for us to introduce some base model (or just use those types in specification\common-types\resource-management\v1\types.json
) to simplify this swagger? For instance the definition of LinkedWorkspace
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
3607043
to
a989319
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
sync changes from Azure#9948
Azure Pipelines successfully started running 1 pipeline(s). |
b646a99
to
c9fe612
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
@ArcturusZhang @pilor those lint failures for "Potential new ARM errors" are unrelated to my changes, they were present even before. Not sure why the LintDiff tool keeps tagging the existing errors as new errors and failing the gate. Can the LintDIff gate be bypassed? |
Azure Pipelines successfully started running 1 pipeline(s). |
@raych1 could you please help us on the LintDiff? |
can you check the following path string : Line 1232 in f4699e5
and Line 1278 in f4699e5
I guess the providers is missed, like '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/linkedWorkspaces'
While having not the providers , the lint tool consider the
|
Hi @keerthiadu could you please resolve the issues in LintDiff according to @jianyexi 's comment? |
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (62 commits) fixed track2 generation (Azure#9848) Update description for requireGuestProvisionSignal. (Azure#9962) Inherent Tracked Resource and Proxy Resource from common types (Azure#9866) Update pull_request_assignment.yml (Azure#10005) Support encryption in transit feature: Add a property when creating a cluster (Azure#9894) updated confluent readme for input files & removed phone number property (Azure#9835) Update compute readme.python.md (Azure#9999) [Hub Generated] Review request for Microsoft.Billing to add version preview/2019-10-01-preview (Azure#9815) Fixed the bad output-folder (Azure#9992) Add preview APIs for deploying Azure machine learning services (Azure#9592) Rename vmware to avs in go SDK (Azure#9903) Add api-version 2020-06-01 of compute for go SDK (Azure#9983) Added 2020-06-01 API version for Microsoft.AppConfiguration. (Azure#9976) separated different error responses (Azure#8881) PersonalDesktopAssignmentType optional (Azure#9988) Feature/alshulma/update stable version (Azure#8884) update error code to use PascalCase to be syned with the library (Azure#8329) CosmosDB - Changes for adding PITR workflow APIs (Azure#9897) update the lva version and few C# autorest parameters (Azure#9990) add cli codegen readme files (Azure#9980) ...
…#9592) * add new preview version * add GET services and example * update description * update description * update tag * add put on services * remove produces and consumes * update examples/description * update examples, use detailed service response * add path for get by service id * add example for getservicebyid * add example for createService * add example for delete service * use full resource uri * add 2020-05-01 to readme * fix modelvalidation checks * add words to cspell ignore list * fix prettier issues * fix model validation * fix lint errors * include newly added templates and exmaples from 2020-04-01-preview * remove UNREFERENCED_JSON_FILE * fix lint and avaocado errors * update description in examples * sync changes from previous preview version Azure#9649 * fix Potential new SDK errors * mark properties on paginated list response as readonly * sync changes from preview/2020-04-01 Azure#9703 * rename operationId * remove createdby * remove createdtime and modifiedtime. Will populate system metadata instead once RP starts populating it. * use 201 instead of 202 on put /services * Revert "remove createdtime and modifiedtime. Will populate system metadata" This reverts commit 8daee90fcdf6d0c96f7802180c8a7d7860c46296. * use servicename parameter instead of id * add apiversionparameter * move PUT from /services to /services/{serivceName} * wrap machine learning service object inside arm resource envelope * fix prettierchecks * set modelAsString to true * dont have to populate operationId * update description of the location * add required fields * use directref instead of allof for containerresourcerequirements * add long running operation on PUT /services/{name} * delete on service is not a long running operation, remove 202 * remove createdtime and modifiedtime. Will populate system metadata instead once RP starts populating it. mark some properties as readonly * update description for ssl cert and ssl key * add description for conda dependencies * add example for service update * set x-ms-secret on authtoken, username and password * fix prettier errors * remove unused file * set readonly for id, name, type. Azure#9948 sync changes from Azure#9948 * on response dont populate username, password and authtoken * set x-ms-azure-resource, sync changes from Azure#9948 * fix lint errors Co-authored-by: Keerthi Adusumilli <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.