Update description for requireGuestProvisionSignal. #9962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
description update only |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Jun 25, 2020
|
Can one of the admins verify this patch? |
|
This looks good to me. |
smotwani
approved these changes
Jun 26, 2020
Sandido
reviewed
Jun 26, 2020
| @@ -8514,7 +8514,7 @@ | |||
| }, | |||
| "requireGuestProvisionSignal": { | |||
| "type": "boolean", | |||
| "description": "Specifies whether the guest provision signal is required to infer provision success of the virtual machine." | |||
| "description": "Specifies whether the guest provision signal is required to infer provision success of the virtual machine. **Note: This property is for private testing only, and all customers must not set the property to false.**" | |||
There was a problem hiding this comment.
Can the customer set this to true or not set it at all? If this parameter has to be set to a value, seems like this should say 'all customers must set this property to true.'
There was a problem hiding this comment.
Customer should set it to true or should not give requireGuestProvisionSignal at all. @Drewm3 can confirm.
There was a problem hiding this comment.
I think it would be more clear to say that all customers must set it to true when used, but it's not a blocking concern so I'll sign off.
Sandido
approved these changes
Jun 29, 2020
fengzhou-msft
removed
the
WaitForARMFeedback
|
@fengzhou-msft Please merge this PR. |
azure-sdk-for-python-track2 - Release
|
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Oct 5, 2020
…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (62 commits) fixed track2 generation (Azure#9848) Update description for requireGuestProvisionSignal. (Azure#9962) Inherent Tracked Resource and Proxy Resource from common types (Azure#9866) Update pull_request_assignment.yml (Azure#10005) Support encryption in transit feature: Add a property when creating a cluster (Azure#9894) updated confluent readme for input files & removed phone number property (Azure#9835) Update compute readme.python.md (Azure#9999) [Hub Generated] Review request for Microsoft.Billing to add version preview/2019-10-01-preview (Azure#9815) Fixed the bad output-folder (Azure#9992) Add preview APIs for deploying Azure machine learning services (Azure#9592) Rename vmware to avs in go SDK (Azure#9903) Add api-version 2020-06-01 of compute for go SDK (Azure#9983) Added 2020-06-01 API version for Microsoft.AppConfiguration. (Azure#9976) separated different error responses (Azure#8881) PersonalDesktopAssignmentType optional (Azure#9988) Feature/alshulma/update stable version (Azure#8884) update error code to use PascalCase to be syned with the library (Azure#8329) CosmosDB - Changes for adding PITR workflow APIs (Azure#9897) update the lva version and few C# autorest parameters (Azure#9990) add cli codegen readme files (Azure#9980) ...
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.