Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alerts management separating error responses with same name #8881

Merged
merged 1 commit into from
Jul 1, 2020
Merged

alerts management separating error responses with same name #8881

merged 1 commit into from
Jul 1, 2020

Conversation

iscai-msft
Copy link
Contributor

Renamed error response to avoid clashes between AlertsManagement and SmartDetectorAlertRulesApi's ErrorResponses

@iscai-msft iscai-msft requested a review from lmazuel March 30, 2020 21:50
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@iscai-msft iscai-msft mentioned this pull request Mar 30, 2020
Merged
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 30, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 30, 2020 •
edited
Loading

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 30, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 30, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 30, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from e36dd21 with merge commit 4646a57. SDK Automation 13.0.17.20200619.4
  • ️✔️azure-mgmt-alertsmanagement [View full logs]  [Release SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-alertsmanagement
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-alertsmanagement
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 3.236% size of original (original: 35229 chars, delta: 1140 chars)
[ChangeLog]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 30, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

This was referenced Mar 30, 2020
Closed
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@raych1 raych1 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required DoNotMerge <valid label in PR review process> use to hold merge after approval labels Mar 31, 2020
KrisBash
KrisBash approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 6, 2020
@raych1
Copy link
Member

raych1 commented Apr 8, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@raych1
Copy link
Member

raych1 commented Jun 30, 2020

@iscai-msft , is this PR ready to merge?

@iscai-msft
Copy link
Contributor Author

yes @raych1

@iscai-msft iscai-msft changed the title [DO NOT MERGE] alerts management separating error responses with same name alerts management separating error responses with same name Jun 30, 2020
@raych1 raych1 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 1, 2020
@raych1 raych1 merged commit 4646a57 into Azure:master Jul 1, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
ce3f34f 
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (62 commits)
  fixed track2 generation (Azure#9848)
  Update description for requireGuestProvisionSignal. (Azure#9962)
  Inherent Tracked Resource and Proxy Resource from common types (Azure#9866)
  Update pull_request_assignment.yml (Azure#10005)
  Support encryption in transit feature: Add a property when creating a cluster (Azure#9894)
  updated confluent readme for input files & removed phone number property (Azure#9835)
  Update compute readme.python.md (Azure#9999)
  [Hub Generated] Review request for Microsoft.Billing to add version preview/2019-10-01-preview (Azure#9815)
  Fixed the bad output-folder (Azure#9992)
  Add preview APIs for deploying Azure machine learning services (Azure#9592)
  Rename vmware to avs in go SDK (Azure#9903)
  Add api-version 2020-06-01 of compute for go SDK (Azure#9983)
  Added 2020-06-01 API version for Microsoft.AppConfiguration. (Azure#9976)
  separated different error responses (Azure#8881)
  PersonalDesktopAssignmentType optional (Azure#9988)
  Feature/alshulma/update stable version (Azure#8884)
  update error code to use PascalCase to be syned with the library (Azure#8329)
  CosmosDB - Changes for adding PITR workflow APIs (Azure#9897)
  update the lva version and few C# autorest parameters (Azure#9990)
  add cli codegen readme files (Azure#9980)
  ...
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@iscai-msft @00Kai0
separated different error responses (Azure#8881)
426a551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raych1 raych1 raych1 approved these changes

@KrisBash KrisBash KrisBash approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

@raych1 raych1

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iscai-msft @azuresdkci @raych1 @KrisBash