Fixing AlertsManagement generation (need to check if parent in yaml is of type object) #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
changed the title
lmazuel
approved these changes
Apr 1, 2020
iscai-msft
added a commit
that referenced
this pull request
Apr 1, 2020
…into fix_config_async_token_credential * 'autorestv3' of https://github.com/Azure/autorest.python: Allows enums to have non-string values (#534) Fixing AlertsManagement generation (need to check if parent in yaml is of type object) (#533) ChangeLog
iscai-msft
added a commit
that referenced
this pull request
Apr 1, 2020
…into autorestv3 * 'autorestv3' of https://github.com/Azure/autorest.python: Fixing AlertsManagement generation (need to check if parent in yaml is of type object) (#533) ChangeLog
iscai-msft
added a commit
that referenced
this pull request
Apr 6, 2020
…s of type object) (#533) * checking if parent is of type object * fixed pylint
iscai-msft
added a commit
that referenced
this pull request
Apr 6, 2020
…into generated_code_mypy_fixes * 'autorestv3' of https://github.com/Azure/autorest.python: Update changelog (#539) Fix config async token credential (#536) Allows enums to have non-string values (#534) Fixing AlertsManagement generation (need to check if parent in yaml is of type object) (#533)
iscai-msft
added a commit
that referenced
this pull request
Apr 7, 2020
…t.python into add_typing_imports * 'add_typing_imports' of https://github.com/Azure/autorest.python: Update ChangeLog.md Add time (#551) changed posted float behavior for non string enums test (#552) Add patch file compatability (#548) Update ChangeLog.md Update ChangeLog.md fix TokenCredential sphinx docstring (#546) fixing default value getting in operation (#545) Update package.json to prepare NPM release (#543) Remove FormData (#541) Update changelog (#539) Fix config async token credential (#536) Allows enums to have non-string values (#534) Fixing AlertsManagement generation (need to check if parent in yaml is of type object) (#533)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #527
had to make changes to swagger, not sure if this is the route we want to go: Azure/azure-rest-api-specs#8881
old autorest would differentiate them by calling one ErrorResponse and one ErrorResponse1