New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated confluent readme for input files & removed phone number property #9835

Merged

erich-wang merged 5 commits into Azure:master from ankisho:Update_readme_inputfile

Jul 1, 2020

Contributor

ankisho commented Jun 13, 2020 •

edited

Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
- adding/removing APIs.
- adding/removing properties.
- adding/removing API-version.
- adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.


          updated confluent readme for input files

7928b7c

openapi-assignment-bot bot assigned erich-wang

openapi-pipeline-app bot commented Jun 13, 2020 •

edited

Loading

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines bot commented Jun 13, 2020

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation bot commented Jun 13, 2020 •

edited

Loading

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 13, 2020 •

edited

Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 13, 2020 •

edited

Loading

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 13, 2020 •

edited

Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 13, 2020 •

edited

Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 13, 2020 •

edited

Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 13, 2020 •

edited

Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 13, 2020 •

edited

Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

Contributor

azuresdkci commented Jun 13, 2020

Can one of the admins verify this patch?


          Removed phone number validation

0de1e4f

azure-pipelines bot commented Jun 15, 2020

Azure Pipelines successfully started running 1 pipeline(s).

openapi-assignment-bot bot added the WaitForARMFeedback label

Contributor Author

ankisho commented Jun 16, 2020

@erich-wang : Could you please review this PR ?

Member

erich-wang commented Jun 17, 2020

@ankisho , the lable WaitForARMFeedbak was added to ask arm review board to review. Adding pattern to existing parameter is kind of break change for customers, has the change been deployed to production?

erich-wang added the Breaking Change Review label


          Removed phone number property

af4ef5d

azure-pipelines bot commented Jun 17, 2020

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

ankisho commented Jun 17, 2020 •

edited

Loading

@ankisho , the lable WaitForARMFeedbak was added to ask arm review board to review. Adding pattern to existing parameter is kind of break change for customers, has the change been deployed to production?

This PR has changes related to removing phone number property. This is breaking change.
right now, this RP is on production but it does not come under private preview yet. This RP is not being used by any of azure end-user. I'm doing internal testing using this RP and Private preview is scheduled for 31st July 2020. I've one more PR with similar changeswith RPaaS team: https://github.com/Azure/azure-rest-api-specs-pr/pull/1449


          updated provision state

c906f76

azure-pipelines bot commented Jun 17, 2020

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

ankisho commented Jun 18, 2020

@erich-wang : Could you please review this PR?

Contributor Author

ankisho commented Jun 19, 2020

Could you please help me to review this PR? @erich-wang

ankisho changed the title ~~updated confluent readme for input files~~ updated confluent readme for input files & removed phone number property

chiragg4u suggested changes

View reviewed changes

Contributor

chiragg4u left a comment

There are breaking changes in this PR. Please take one of the options

confirm if there is no customers for this version
update the API version
follow Azure Breaking changes approval request form as defined @ Breaking Change Process

...ion/confluent/resource-manager/Microsoft.Confluent/preview/2020-03-01-preview/confluent.json

@@ @@ -538,8 +538,7 @@ @@
                         "type": "string"
                       },
                       "phoneNumber": {
-                        "description": "Phone number. Validation Pattern: ^(\\+\\d{1,2}\\s)?\\(?\\d{3}\\)?[\\s.-]?\\d{3}[\\s.-]?\\d{4}$",
-                        "pattern": "^(\\+\\d{1,2}\\s)?\\(?\\d{3}\\)?[\\s.-]?\\d{3}[\\s.-]?\\d{4}$",

Contributor

chiragg4u Jun 15, 2020

Please review the breaking change. Why is this change required?

Contributor Author

ankisho Jun 19, 2020

This change is required as we had discussion with ISV Confluent. We & confluent ISV are decided that phone number is not required for this RP and requested to remove this.

Contributor Author

ankisho commented Jun 19, 2020

There are breaking changes in this PR. Please take one of the options

confirm if there is no customers for this version

update the API version

follow Azure Breaking changes approval request form as defined @ Breaking Change Process

This PR has changes related to removing phone number property. This is breaking change.
right now, this RP is in production behind hidden feature flag but it does not come under private preview yet. This RP is not being used by any of azure end-user. I'm doing internal testing using this RP and Private preview is scheduled for 31st July 2020.
I've one more PR with similar changes with RPaaS team: https://github.com/Azure/azure-rest-api-specs-pr/pull/1449

chiragg4u approved these changes

View reviewed changes

Contributor

chiragg4u left a comment

Approving based as the feature is under testing.

chiragg4u added Approved-BreakingChange ARMSignedOff and removed Breaking Change Review WaitForARMFeedback labels

Contributor Author

ankisho commented Jun 20, 2020

Approving based as the feature is under testing.

thanks

Contributor Author

ankisho commented Jun 22, 2020

@erich-wang : Could you please prioritize the merge of this PR? This is blocking the ARM template generation task.

erich-wang approved these changes

View reviewed changes

Member

erich-wang commented Jun 27, 2020

@akning-ms, could you please force merge this PR?

Contributor Author

ankisho commented Jun 27, 2020

@akning-ms, could you please force merge this PR?

@erich-wang @akning-ms : I have a question about this swagger json. we are currently on private preview stage of RP development. since this repo is a public repo, should we merge this swagger to public repo before public private stage?

Contributor

akning-ms commented Jun 28, 2020

Hi @ankisho, Normally, for private review. you can just submit PR in azure-rest-api-specs-pr(private repo). but looks your preview version 2020-03-01-preview was already in public repo, this PR is just kind of fix. so you can continue your merge for this version if you want. so let us know your thoughts


          Removing preview version from Azure public repo

31d1e93

azure-pipelines bot commented Jun 30, 2020

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

ankisho commented Jun 30, 2020

Hi @ankisho, Normally, for private review. you can just submit PR in azure-rest-api-specs-pr(private repo). but looks your preview version 2020-03-01-preview was already in public repo, this PR is just kind of fix. so you can continue your merge for this version if you want. so let us know your thoughts

Hi @akning-ms , i've some updates regarding this.
since, confluent RP is going for private preview phase now(july 2020 end). we have decided that it'd be good if we can expose the confluent RP schema spec to public from Public preview or GA phase. Hence, i've updated this PR to remove the confluent spec from this public repo. Kindly review.

erich-wang merged commit 553d68e into Azure:master

iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request


          Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

ce3f34f

…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (62 commits)
  fixed track2 generation (Azure#9848)
  Update description for requireGuestProvisionSignal. (Azure#9962)
  Inherent Tracked Resource and Proxy Resource from common types (Azure#9866)
  Update pull_request_assignment.yml (Azure#10005)
  Support encryption in transit feature: Add a property when creating a cluster (Azure#9894)
  updated confluent readme for input files & removed phone number property (Azure#9835)
  Update compute readme.python.md (Azure#9999)
  [Hub Generated] Review request for Microsoft.Billing to add version preview/2019-10-01-preview (Azure#9815)
  Fixed the bad output-folder (Azure#9992)
  Add preview APIs for deploying Azure machine learning services (Azure#9592)
  Rename vmware to avs in go SDK (Azure#9903)
  Add api-version 2020-06-01 of compute for go SDK (Azure#9983)
  Added 2020-06-01 API version for Microsoft.AppConfiguration. (Azure#9976)
  separated different error responses (Azure#8881)
  PersonalDesktopAssignmentType optional (Azure#9988)
  Feature/alshulma/update stable version (Azure#8884)
  update error code to use PascalCase to be syned with the library (Azure#8329)
  CosmosDB - Changes for adding PITR workflow APIs (Azure#9897)
  update the lva version and few C# autorest parameters (Azure#9990)
  add cli codegen readme files (Azure#9980)
  ...

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request


          updated confluent readme for input files & removed phone number prope…

4d5827a

…rty (Azure#9835)

* updated confluent readme for input files

* Removed phone number validation

* Removed phone number property

* updated provision state

* Removing preview version from Azure public repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange ARMSignedOff