-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Api version 2020-06-15- fixing certificate put/get issues with ARM #10251
Merged
ruowan
merged 14 commits into
Azure:master
from
deepak-muniappan:dev-iothub-Microsoft.Devices-2020-06-15
Aug 1, 2020
Merged
New Api version 2020-06-15- fixing certificate put/get issues with ARM #10251
ruowan
merged 14 commits into
Azure:master
from
deepak-muniappan:dev-iothub-Microsoft.Devices-2020-06-15
Aug 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-java
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Jul 27, 2020
Hi, pls fix CI failure. |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
signing off from arm side. |
ravbhatnagar
added
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
and removed
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Jul 28, 2020
ruowan
approved these changes
Jul 30, 2020
You could ignore the dot net SDK generates failure. It's build error and no effect for downstream. LGTM, ready to merge? |
Azure Pipelines successfully started running 1 pipeline(s). |
4 similar comments
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
avranju
force-pushed
the
dev-iothub-Microsoft.Devices-2020-06-15
branch
from
July 31, 2020 06:15
06ba227
to
47753c4
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
ruowan
approved these changes
Aug 1, 2020
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Oct 5, 2020
…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (29 commits) Add preAttack tactic to swagger (Azure#10332) Add Url Signing action definition (Azure#10326) [Synapse] Support long running operation and add subclass of Activity in artifact (Azure#10270) Add native blob soft delete (Azure#10308) Fix Microsoft.Resources naming issue (Azure#10318) Notebooks swagger spec (Azure#9841) Add network profile in Spring payload. (Azure#10313) Fix output-folder for go SDK in timeseriesinsight (Azure#10300) Alias Put Subscription API (Azure#10205) resource-resource-2019-03-01-python-config (Azure#10314) New Api version 2020-06-15- fixing certificate put/get issues with ARM (Azure#10251) [DataFactory] Support source sink level staging (Azure#10290) Added swagger files for PostgreSQL Flexible Server preview (Azure#10020) [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview (Azure#10302) Adding Untracked Public Maintenance Config Resource Type (Azure#10281) add assignment resource id to the schema (Azure#10309) [datashare] sort api's and definitions (Azure#10273) Update readme.md all-api-versions tags (Azure#10296) Documentation updated (Azure#10283) [CosmosDB] Migration support of existing containers/databases to autoscale (Azure#9258) ...
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
Azure#10251) * Adds base for updating Microsoft.Devices from version stable/2020-04-01 to version 2020-06-15 * Updates readme * Updates API version in new specs and examples * Add cert changes * Fix examples * remove unnecessary model * fix the createcert * Fix the put certificate body * Fix the certificate example * Fix the braces * Fix the certificateDescription case * Prettify Json * Update consumer group properties PUT schema * Rename schema prop name for cg body Co-authored-by: Rajasekharan Vengalil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.