Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AML Workspace ID Property #10073

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

mvvsubbu
Copy link
Contributor

@mvvsubbu mvvsubbu commented Jul 9, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 9, 2020

[Staging] Swagger Validation Report

BreakingChange: 1 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1041 - AddedPropertyInResponse The new version has a new property 'amlWorkspaceId' in response that was not found in the old version.
New: Microsoft.Databricks/stable/2018-04-01/databricks.json#L837:7
Old: Microsoft.Databricks/stable/2018-04-01/databricks.json#L837:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from d397510 with merge commit c13a24a. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-databricks [View full logs]  [Release SDK Changes]
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/databricksClient.js → ./dist/arm-databricks.js...
    [npmPack] created ./dist/arm-databricks.js in 244ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 64.5kB  dist/arm-databricks.js                
    [npmPack] npm notice 21.9kB  dist/arm-databricks.min.js            
    [npmPack] npm notice 1.6kB   esm/databricksClient.js               
    [npmPack] npm notice 2.5kB   esm/databricksClientContext.js        
    [npmPack] npm notice 345B    esm/models/index.js                   
    [npmPack] npm notice 442B    esm/operations/index.js               
    [npmPack] npm notice 23.4kB  esm/models/mappers.js                 
    [npmPack] npm notice 2.3kB   esm/operations/operations.js          
    [npmPack] npm notice 482B    esm/models/operationsMappers.js       
    [npmPack] npm notice 2.0kB   esm/models/parameters.js              
    [npmPack] npm notice 982B    rollup.config.js                      
    [npmPack] npm notice 8.8kB   esm/operations/vNetPeering.js         
    [npmPack] npm notice 883B    esm/models/vNetPeeringMappers.js      
    [npmPack] npm notice 11.3kB  esm/operations/workspaces.js          
    [npmPack] npm notice 893B    esm/models/workspacesMappers.js       
    [npmPack] npm notice 1.6kB   package.json                          
    [npmPack] npm notice 457B    tsconfig.json                         
    [npmPack] npm notice 126.7kB dist/arm-databricks.js.map            
    [npmPack] npm notice 19.1kB  dist/arm-databricks.min.js.map        
    [npmPack] npm notice 678B    esm/databricksClient.d.ts.map         
    [npmPack] npm notice 802B    esm/databricksClient.js.map           
    [npmPack] npm notice 498B    esm/databricksClientContext.d.ts.map  
    [npmPack] npm notice 1.4kB   esm/databricksClientContext.js.map    
    [npmPack] npm notice 8.5kB   esm/models/index.d.ts.map             
    [npmPack] npm notice 179B    esm/operations/index.d.ts.map         
    [npmPack] npm notice 126B    esm/models/index.js.map               
    [npmPack] npm notice 194B    esm/operations/index.js.map           
    [npmPack] npm notice 1.5kB   esm/models/mappers.d.ts.map           
    [npmPack] npm notice 13.1kB  esm/models/mappers.js.map             
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map    
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map      
    [npmPack] npm notice 235B    esm/models/operationsMappers.d.ts.map 
    [npmPack] npm notice 248B    esm/models/operationsMappers.js.map   
    [npmPack] npm notice 492B    esm/models/parameters.d.ts.map        
    [npmPack] npm notice 1.5kB   esm/models/parameters.js.map          
    [npmPack] npm notice 2.4kB   esm/operations/vNetPeering.d.ts.map   
    [npmPack] npm notice 4.2kB   esm/operations/vNetPeering.js.map     
    [npmPack] npm notice 411B    esm/models/vNetPeeringMappers.d.ts.map
    [npmPack] npm notice 424B    esm/models/vNetPeeringMappers.js.map  
    [npmPack] npm notice 3.3kB   esm/operations/workspaces.d.ts.map    
    [npmPack] npm notice 5.9kB   esm/operations/workspaces.js.map      
    [npmPack] npm notice 420B    esm/models/workspacesMappers.d.ts.map 
    [npmPack] npm notice 433B    esm/models/workspacesMappers.js.map   
    [npmPack] npm notice 3.4kB   README.md                             
    [npmPack] npm notice 1.0kB   esm/databricksClient.d.ts             
    [npmPack] npm notice 1.5kB   src/databricksClient.ts               
    [npmPack] npm notice 782B    esm/databricksClientContext.d.ts      
    [npmPack] npm notice 2.3kB   src/databricksClientContext.ts        
    [npmPack] npm notice 24.4kB  esm/models/index.d.ts                 
    [npmPack] npm notice 126B    esm/operations/index.d.ts             
    [npmPack] npm notice 23.5kB  src/models/index.ts                   
    [npmPack] npm notice 410B    src/operations/index.ts               
    [npmPack] npm notice 2.0kB   esm/models/mappers.d.ts               
    [npmPack] npm notice 18.9kB  src/models/mappers.ts                 
    [npmPack] npm notice 2.0kB   esm/operations/operations.d.ts        
    [npmPack] npm notice 4.1kB   src/operations/operations.ts          
    [npmPack] npm notice 172B    esm/models/operationsMappers.d.ts     
    [npmPack] npm notice 450B    src/models/operationsMappers.ts       
    [npmPack] npm notice 546B    esm/models/parameters.d.ts            
    [npmPack] npm notice 2.0kB   src/models/parameters.ts              
    [npmPack] npm notice 6.7kB   esm/operations/vNetPeering.d.ts       
    [npmPack] npm notice 12.7kB  src/operations/vNetPeering.ts         
    [npmPack] npm notice 573B    esm/models/vNetPeeringMappers.d.ts    
    [npmPack] npm notice 880B    src/models/vNetPeeringMappers.ts      
    [npmPack] npm notice 8.5kB   esm/operations/workspaces.d.ts        
    [npmPack] npm notice 16.7kB  src/operations/workspaces.ts          
    [npmPack] npm notice 583B    esm/models/workspacesMappers.d.ts     
    [npmPack] npm notice 893B    src/models/workspacesMappers.ts       
    [npmPack] npm notice 1.1kB   LICENSE.txt                           
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          @azure/arm-databricks                   
    [npmPack] npm notice version:       1.1.0                                   
    [npmPack] npm notice filename:      azure-arm-databricks-1.1.0.tgz          
    [npmPack] npm notice package size:  55.2 kB                                 
    [npmPack] npm notice unpacked size: 475.6 kB                                
    [npmPack] npm notice shasum:        0a49371ea680e501739b242657f139a290175b0e
    [npmPack] npm notice integrity:     sha512-R/oNGkl7dp6IT[...]2JVXYRoRFT6zw==
    [npmPack] npm notice total files:   69                                      
    [npmPack] npm notice 

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from d397510 with merge commit c13a24a. SDK Automation 13.0.17.20200619.4
  • ️✔️azure-mgmt-databricks [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-databricks
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-databricks
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 60.743% size of original (original: 15238 chars, delta: 9256 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model Workspace has a new parameter storage_account_identity
    [ChangeLog]   - Model Workspace has a new parameter workspace_id
    [ChangeLog]   - Model Workspace has a new parameter created_date_time
    [ChangeLog]   - Model Workspace has a new parameter workspace_url
    [ChangeLog]   - Model Workspace has a new parameter updated_by
    [ChangeLog]   - Model Workspace has a new parameter created_by
    [ChangeLog]   - Added operation group VNetPeeringOperations

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link

@shafqatanwar shafqatanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we already had this parameter? I guess it was missing form swagger, i assume?

@mvvsubbu
Copy link
Contributor Author

I thought we already had this parameter? I guess it was missing form swagger, i assume?

Yes this was not exposed, but now we are suggesting to unlink via ARM template deployment and hence this parameter should be visible in ARM template reference. So adding in swagger

@fengzhou-msft
Copy link
Member

As identified in the automated checks there are breaking changes, please follow Azure Breaking changes approval request form as defined @Breaking Change Process

@mvvsubbu
Copy link
Contributor Author

As identified in the automated checks there are breaking changes, please follow Azure Breaking changes approval request form as defined @Breaking Change Process

This change is not breaking change. The current property is already supported by our service and we are exposing it in swagger. This is an optional parameter which don't need to specify always. Let us know if we want to discuss further on this.

@fengzhou-msft fengzhou-msft added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed BreakingChangeReviewRequired labels Jul 25, 2020
@fengzhou-msft fengzhou-msft merged commit c13a24a into master Jul 25, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 25, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (154 commits)
  Key Vault 7.1-preview to stable (GA) (Azure#10239)
  Fix data plane cosmosdb (Azure#10277)
  Fix example request for expanding policyEvaluationDetails (Azure#10203)
  Databricks Swagger Changes for Double Encryption (Azure#9941)
  add column delimiter for SAP Table/open hub (Azure#10269)
  add doc for typescript md (Azure#10187)
  Fix sfrp 2020-01-01-preview (Azure#10268)
  [Datafactory]Add cloudType and snapshot to ADF public swagger (Azure#10235)
  Migrate TaskRun to ProxyResource. (Azure#9953)
  [Datashare]Add sorting query parameters (Azure#10209)
  [Hub Generated] Review request for Microsoft.Insights to add version preview/2018-06-17-preview (Azure#10173)
  Update dataController onPremise property (Azure#10263)
  Changed the Client description to include Gen2 (Azure#10178)
  Managed Clusters Generate SDK (Azure#10247)
  Dev monitor microsoft.insights 2020 05 01 preview (Azure#10101)
  Add Location property to ExportPipeline and ImportPipeline (Azure#10177)
  Add enableAutomaticUpgrade property to VMExtensions for VMs and VMSS (Azure#10134)
  Add a new api and add 2020-02-02-preview versions (Azure#9710)
  Adding AML Workspace ID Property (Azure#10073)
  Add missing nullable attributes (Azure#10245)
  ...
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@JackTn JackTn deleted the users/subraman/amlworkspaceparam branch August 9, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants