Use me exceptions flyouts #15
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…na into use_me_exceptions_flyouts
…ed (elastic#142409) Co-authored-by: Kibana Machine <[email protected]>
Updated copy on the pipelines tab and modal when using an API-based index to explicitly call-out required actions in API requests to run the ingest pipeline.
Co-authored-by: Patryk Kopycinski <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
…vent warnings (elastic#142259) * Serialize errors before sending to redux store to prevent warnings. * Serialize response errors in monitor list effect.
…ssue. (elastic#142524) * removed complex lines per frame logic. caused too many edge cases. tests added to prevent future regressions * fix fit to screen option (when changing from fullscreen to not. also button state). increased playback speed to make up for removal of multi line per frame rendering * fixed tests * removing tty loading technique due to problems with unique char_device in multi container sessions on the same pod Co-authored-by: Karl Godard <[email protected]>
…ntrols (elastic#141824) * [Sample data] replace legacy control visualizations with dashboard controls * i18n wrappings for title and description * update screen shots * fix functional tests * update functional test expects * more functional test expect updates Co-authored-by: Kibana Machine <[email protected]>
…ule (elastic#142505) * Running task using scheduled task id. Adding functional test * dont run if rule is disable * Fixing i18n
) Co-authored-by: Faisal Kanout <[email protected]>
* Refactor global_query_string to move reusabel code to helper * Add Url state parameter for external alerts checkbox Co-authored-by: Kibana Machine <[email protected]>
…e to prevent warnings (elastic#142259)" This reverts commit b3a749e.
…lastic#142464) ## Summary - addresses elastic#138757 according to proposal in above task: - removes step of updating immutable rule with mock data - makes assertions whether rule properties were not modified against fetched earlier immutable rule ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Co-authored-by: kibanamachine <[email protected]>
…42320) By default, mark `allStepsLoading = true` where steps loading isn't important.
…42477) * [Infra] Make nav react to Hosts view enabled flag changing (elastic#140996) * Move comment to more relevant location Co-authored-by: Kibana Machine <[email protected]>
…2864) * prevent high number of re-renders of package grid * fix hook tests
Co-authored-by: Kibana Machine <[email protected]>
* [Draft][Lens] Bundle Size Reduction * fix JEST * update some imports * Update x-pack/plugins/lens/common/expressions/datatable/sorting.tsx Co-authored-by: Marco Liberati <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marco Liberati <[email protected]>
* ♻️ Refactor mocks * ♻️ First rewrite with operation mocks * Update x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/formula/editor/math_completion.test.ts Co-authored-by: Marta Bondyra <[email protected]> Co-authored-by: Marta Bondyra <[email protected]>
…stic#142019) * Add maxIdleSockets and idleSocketTimeout to Elasticsearch config * Simplify agent manager * Fix types * Fix types * Reduce idleSocketTimeout default to 60s * Fix tests * Update docs/setup/settings.asciidoc * Address review comments Co-authored-by: Kibana Machine <[email protected]>
* [XY] Fixes the colors and tooltips sync * Fix types * Fix jest tests
* feat: OrFilter -> CombinedFilter * [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs' * feat: updated filter's type OR -> combined * fix: jest test
… action according to test plan (elastic#141929) ## Summary - adds missing tests according to [test plan](https://docs.google.com/document/d/116x7ITTTJQ6cTiwaGK831_f6Ox7XB3qyLiHxC3Cmf8w/edit#heading=h.tzaw2977z8ue) (internal document) - small refactoring of cypress tasks related to rule actions: create Email connector moved to common tasks from create_rule screen, as it used in bulk editing as well
* ✅ Add tests for feature * ✨ Add feature and make tests work * ✨ Add more ui stuff * 🐛 Fix missing renders on advanced options change * 🔧 fix id issue * 👌 Shorter tooltip message
…c#142962) * ✏️ Update error messages * 🔧 fix unused imports
Co-authored-by: Kibana Machine <[email protected]>
* Re-enable Bazel cache on CI * remove exit test
…ntegration/test_suites/task_manager/task_management·ts - task_manager scheduling and running tasks should disable and reenable task and not run it when runSoon = false (elastic#142749) * Unskipping test * Adding some console logs * Comparing strings * Setting date beforehand * Comparing against disabled task * Reverting unnecessary changes * Cleanup Co-authored-by: Kibana Machine <[email protected]>
* [Console] Add tests for XJSON * Convert rgb to hex * Address CR changes * Expand test coverage for XJSON * Retry until typing is finished Co-authored-by: Muhammad Ibragimov <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
* Add severity action * Change translation * Add unit tests * Add e2e tests * Fix i18n * PR feedback Co-authored-by: Kibana Machine <[email protected]>
…talled from a Fleet package (elastic#142311)
…field (elastic#142945) * add index pattern setter and getter and deprecate title field
… but flags as error on re-edit (elastic#142225) * Fixing es query bug * Updating threshold * Adding isNil to another check
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jonathan Budzenski <[email protected]>
This reverts commit 783997b.
* [DOCS] Adds content on ad hoc data view * [DOCS] Breaks data into two steps * Update docs/concepts/data-views.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * [DOCS] Tweaks message re: unsaved data views Co-authored-by: Kaarina Tungseth <[email protected]>
…#142602) ## Summary - addresses elastic#141758 - loads saved query on rules edit page before form rendering, thus prevents validation run on uncompleted data(saved query wasn't fetched before QueryBar component renders). Then fetched saved query passed to QueryBarDefineRule component ### Before https://user-images.githubusercontent.com/92328789/193884969-3647e06b-085a-4923-82e8-546bedabeb3e.mp4 ### After https://user-images.githubusercontent.com/92328789/193884323-629fb879-3a51-4412-8b63-2f36afc618cb.mov As side effect, it reduced number of requests for saved query: #### Before 2 requests were sent <img width="1995" alt="Screenshot 2022-10-05 at 09 39 09" src="https://user-images.githubusercontent.com/92328789/194018652-5612a032-e908-4e01-9858-2049c8e453e2.png"> #### After Only one request sent ### Checklist <img width="1996" alt="Screenshot 2022-10-05 at 09 37 12" src="https://user-images.githubusercontent.com/92328789/194018637-770a08df-832b-4838-a060-05058c436ed6.png"> Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers