Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Trusted Apps about text updated to add new docs link #142467

Merged
merged 12 commits into from
Oct 3, 2022
Merged

[Security Solution] Trusted Apps about text updated to add new docs link #142467

merged 12 commits into from
Oct 3, 2022

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented Oct 3, 2022 •
edited by kibanamachine
Loading

Summary

Update the Trusted Apps about text in the Empty State, list page, and create fly out to contain a new docs link with docs about the difference between some user artifacts.

NOTE: We are still waiting on the new docs page to be merged, but the surrounding logic is ready for review. Will update this PR when the docs are merged.

A docs stub link has been added so that this PR can go through. When this PR is merged, the actual content will be in place.

Empty state:
image

Create flyout:
image

List page:
image

Checklist

Delete any items that are not applicable to this PR.

@kevinlog kevinlog added release_note:enhancement Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.5.0 v8.6.0 labels Oct 3, 2022
@joepeeples joepeeples mentioned this pull request Oct 3, 2022
Merged
@kevinlog kevinlog marked this pull request as ready for review October 3, 2022 17:01
@kevinlog kevinlog requested review from a team as code owners October 3, 2022 17:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@kevinlog kevinlog requested review from pzl and ashokaditya October 3, 2022 17:01
@kevinlog
Copy link
Contributor Author

kevinlog commented Oct 3, 2022

@elasticmachine merge upstream

joepeeples
joepeeples approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI copy LGTM, and docs link is now live (published in elastic/security-docs#2530, backported to 8.5 in elastic/security-docs#2532).

gchaps
gchaps approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doclink LGTM. Thanks @joepeeples. Reviewed on behalf of kibana-docs.

@kevinlog kevinlog enabled auto-merge (squash) October 3, 2022 19:00
@joepeeples joepeeples mentioned this pull request Oct 3, 2022
Merged
@kevinlog
Copy link
Contributor Author

kevinlog commented Oct 3, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3150 3151 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.6MB 6.6MB +1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 366.8KB 366.8KB +57.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kevinlog kevinlog merged commit 44d028f into elastic:main Oct 3, 2022
@kibanamachine kibanamachine mentioned this pull request Oct 3, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 3, 2022
@kevinlog
[Security Solution] Trusted Apps about text updated to add new docs l…
fd25995 
…ink (elastic#142467)

(cherry picked from commit 44d028f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 3, 2022
@kibanamachine @kevinlog
[Security Solution] Trusted Apps about text updated to add new docs l…
e763e04 
…ink (#142467) (#142534)

(cherry picked from commit 44d028f)

Co-authored-by: Kevin Logan <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@kevinlog @WafaaNasr
[Security Solution] Trusted Apps about text updated to add new docs l…
c995d39 
…ink (elastic#142467)
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@kevinlog @WafaaNasr
[Security Solution] Trusted Apps about text updated to add new docs l…
012eb2d 
…ink (elastic#142467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples approved these changes

@gchaps gchaps gchaps approved these changes

@joeypoon joeypoon joeypoon approved these changes

@pzl pzl pzl approved these changes

@ashokaditya ashokaditya Awaiting requested review from ashokaditya ashokaditya was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

Assignees
No one assigned
Labels
release_note:enhancement Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kevinlog @elasticmachine @kibana-ci @kibanamachine @pzl @joeypoon @gchaps @joepeeples