Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] pipelines copy tweaks #142406

Merged

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Sep 30, 2022

Summary

Updated copy on the pipelines tab and modal when using an API-based index to explicitly call-out required actions in API requests to run the ingest pipeline.

image

image

Checklist

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.6.0 v8.5.1 labels Sep 30, 2022
@TattdCodeMonkey TattdCodeMonkey requested review from a team and daveyholler September 30, 2022 19:06
@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/es/pipelines-tweaks branch from 6e956c6 to 8d28b7f Compare October 3, 2022 15:39
Updated copy on the pipelines tab and modal when using an API-based
index to explicitly call-out required actions in API requests to run the
ingest pipeline.
@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/es/pipelines-tweaks branch from 8d28b7f to 40dedf9 Compare October 3, 2022 15:57
Copy link

@jgr jgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I'm not sure how I feel about the term "API-based index" but that clearly predates this change.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #27 / transform creation_index_pattern batch transform with terms+date_histogram groups and avg agg navigates through the wizard and sets all needed fields
  • [job] [logs] FTR Configs #27 / transform creation_index_pattern batch transform with terms+date_histogram groups and avg agg navigates to discover and displays results of the destination index
  • [job] [logs] FTR Configs #27 / transform creation_index_pattern batch transform with terms+date_histogram groups and avg agg runs the transform and displays it correctly in the job list

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB +1.2KB

History

  • 💚 Build #77272 succeeded 6e956c694e6b27cc79d84b4c6603d3449d25d702

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit 9a8008b into elastic:main Oct 3, 2022
@TattdCodeMonkey TattdCodeMonkey deleted the rnorris/es/pipelines-tweaks branch October 3, 2022 21:54
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 3, 2022
Updated copy on the pipelines tab and modal when using an API-based
index to explicitly call-out required actions in API requests to run the
ingest pipeline.

(cherry picked from commit 9a8008b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 3, 2022
Updated copy on the pipelines tab and modal when using an API-based
index to explicitly call-out required actions in API requests to run the
ingest pipeline.

(cherry picked from commit 9a8008b)

Co-authored-by: Rodney Norris <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
Updated copy on the pipelines tab and modal when using an API-based
index to explicitly call-out required actions in API requests to run the
ingest pipeline.
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Updated copy on the pipelines tab and modal when using an API-based
index to explicitly call-out required actions in API requests to run the
ingest pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants