Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Alerting] Elasticsearch query rule type allows SIZE: 0, but flags as error on re-edit #142225

Merged
merged 6 commits into from
Oct 10, 2022
Merged

[ResponseOps][Alerting] Elasticsearch query rule type allows SIZE: 0, but flags as error on re-edit #142225

merged 6 commits into from
Oct 10, 2022

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Sep 29, 2022 •
edited
Loading

Resolves #138759

Summary

Adds a null check to the form validation so that a value of 0 doesnt cause errors.

Checklist

To verify

  • Create an es query rule with the size set to 0. Verify that there are no errors
  • Try to edit that es query rule, and verify that there are no errors on the edit form when you open it

@doakalexi doakalexi changed the title Fixing es query bug [ResponseOps][Alerting] Elasticsearch query rule type allows SIZE: 0, but flags as error on re-edit Sep 29, 2022
@doakalexi doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:fix labels Sep 29, 2022
@doakalexi doakalexi requested a review from a team September 29, 2022 14:50
@doakalexi doakalexi marked this pull request as ready for review September 29, 2022 14:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1
Copy link
Contributor

ymao1 commented Sep 29, 2022

Is this fix something we could also do for the threshold conditions fields on the ES Query and Index Threshold rule types?
Screen Shot 2022-09-29 at 2 52 00 PM

Screen Shot 2022-09-29 at 2 52 44 PM

@doakalexi
Copy link
Contributor Author

doakalexi commented Sep 29, 2022 •
edited
Loading

Is this fix something we could also do for the threshold conditions fields on the ES Query and Index Threshold rule types?

sure! I can do that
Resolved in f2477e4

ymao1
ymao1 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ersin-erdal
ersin-erdal approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a note for a small fix.
After that, LGTM

@doakalexi doakalexi enabled auto-merge (squash) October 10, 2022 13:33
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 671.8KB 671.9KB +40.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackAlerts 13.9KB 13.9KB +17.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@doakalexi doakalexi merged commit b542f7b into elastic:main Oct 10, 2022
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 10, 2022
@doakalexi doakalexi deleted the alerting/es-query-size branch December 6, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@ersin-erdal ersin-erdal ersin-erdal approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ResponseOps] elasticsearch query rule type allows SIZE: 0, but flags as error on re-edit
6 participants
@doakalexi @elasticmachine @ymao1 @kibana-ci @ersin-erdal @kibanamachine