Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Add tests for XJSON #136711

Merged
merged 10 commits into from
Oct 10, 2022
Merged

[Console] Add tests for XJSON #136711

merged 10 commits into from
Oct 10, 2022

Conversation

mibragimov
Copy link
Contributor

@mibragimov mibragimov commented Jul 20, 2022 •
edited
Loading

Closes #136055
Closes #131443

Summary

This PR adds functional tests for the following XJSON feature in Console:

  • Inline HTTP requests
  • Multiple bodies for _msearch requests
  • Multiple JSON blocks
  • Triple quoted strings escape quotes
  • Inline comments
  • Inline deprecation warnings

Checklist

@mibragimov mibragimov added Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jul 20, 2022
@mibragimov mibragimov requested a review from alexwizp July 20, 2022 09:33
@mibragimov mibragimov self-assigned this Jul 20, 2022
@mibragimov mibragimov mentioned this pull request Jul 21, 2022
Merged
@mibragimov mibragimov force-pushed the console/extended-json-tests branch from bf3f0f2 to d87c6b4 Compare August 8, 2022 05:39
alexwizp
alexwizp approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general LGTM, please open that PR

@mibragimov mibragimov force-pushed the console/extended-json-tests branch 2 times, most recently from f069ed4 to 048bd70 Compare August 30, 2022 09:29
@mibragimov mibragimov force-pushed the console/extended-json-tests branch 3 times, most recently from 2cffc98 to 4e9b99f Compare August 31, 2022 10:15
@mibragimov
Copy link
Contributor Author

Verified the tests through the flaky test runner ~200 times https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1120

@mibragimov
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@mibragimov
Copy link
Contributor Author

@elasticmachine merge upstream

@mibragimov mibragimov force-pushed the console/extended-json-tests branch from 8f4cc32 to 06b1fdd Compare September 23, 2022 10:22
@mibragimov mibragimov added v8.6.0 and removed v8.4.0 labels Sep 23, 2022
@mibragimov mibragimov added the test-coverage issues & PRs for improving code test coverage label Sep 23, 2022
@mibragimov mibragimov force-pushed the console/extended-json-tests branch from 06b1fdd to b251424 Compare September 26, 2022 09:36
@mibragimov mibragimov force-pushed the console/extended-json-tests branch from b251424 to d5441c4 Compare September 26, 2022 12:46
@mibragimov
Copy link
Contributor Author

Ran the flaky test runner ~200 times each on chrome and firefox and it all passed
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1320

@mibragimov
Copy link
Contributor Author

@elasticmachine merge upstream

@mibragimov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mibragimov

sabarasaba
sabarasaba approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, thanks @mibragimov!

@mibragimov mibragimov marked this pull request as ready for review October 10, 2022 13:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@mibragimov mibragimov merged commit dfede09 into elastic:main Oct 10, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 10, 2022
@mibragimov mibragimov deleted the console/extended-json-tests branch October 10, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees

@mibragimov mibragimov

Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-coverage issues & PRs for improving code test coverage v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for "extended JSON" (XJSON) Tests for Ace editor error while adding second request
6 participants
@mibragimov @kibana-ci @elasticmachine @sabarasaba @alexwizp @kibanamachine