Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Fix syntax highlighting for triple quotes #136719

Merged
merged 4 commits into from
Jul 22, 2022
Merged

[Console] Fix syntax highlighting for triple quotes #136719

merged 4 commits into from
Jul 22, 2022

Conversation

mibragimov
Copy link
Contributor

Closes #136717

Summary

Fixes the syntax highlighting for the triple quoted strings

Screen Shot 2022-07-20 at 17 19 53

@mibragimov mibragimov added Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jul 20, 2022
@mibragimov mibragimov requested a review from alexwizp July 20, 2022 12:29
@mibragimov mibragimov requested a review from a team as a code owner July 20, 2022 12:29
@mibragimov mibragimov self-assigned this Jul 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

cjcenizal
cjcenizal approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test locally, code LGTM.

@cjcenizal
Copy link
Contributor

@mibragimov Is there a way to add a test for this?

@mibragimov mibragimov force-pushed the console/triple-quotes-bug branch from ef23e32 to 925e8ef Compare July 21, 2022 10:03
@mibragimov
Copy link
Contributor Author

@mibragimov Is there a way to add a test for this?

Added a couple of tests for this case. I was thinking of including them with #136711. Once we merge #136711, this newly added test file _xjson will be populated with more tests

@mibragimov mibragimov force-pushed the console/triple-quotes-bug branch from f54c79f to 6074722 Compare July 22, 2022 09:49
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 397.5KB 397.6KB +94.0B

History

  • 💚 Build #59757 succeeded f54c79f8a578b580af4c1a03f62df50fe3bef2ff
  • 💚 Build #59418 succeeded 925e8ef1e7d4260c6476b64d2fd9e3dcc0309277
  • 💚 Build #59073 succeeded ef23e32299b239ddd8384d004ee07e4599f04fd4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mibragimov

@mibragimov mibragimov added ci:skip-when-possible (Deprecated) no-op, managed automatically and removed ci:skip-when-possible (Deprecated) no-op, managed automatically labels Jul 22, 2022
@mibragimov
Copy link
Contributor Author

Verified functional tests ~200 times https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/918

@mibragimov mibragimov added v8.4.0 backport:skip This commit does not require backporting and removed v8.4.0 labels Jul 22, 2022
@mibragimov mibragimov merged commit 4ad72fc into elastic:main Jul 22, 2022
@mibragimov mibragimov deleted the console/triple-quotes-bug branch July 22, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@mibragimov mibragimov

Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Console] Syntax highlighting for triple quotes broken
4 participants
@mibragimov @elasticmachine @cjcenizal @kibana-ci