Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sample data] replace legacy control visualizations with dashboard controls #141824

Merged
merged 10 commits into from
Oct 4, 2022
Merged

[Sample data] replace legacy control visualizations with dashboard controls #141824

merged 10 commits into from
Oct 4, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Sep 26, 2022 •
edited
Loading

PR replaces legacy control visualizations with dashboard controls in sample data set dashboards

Updated screen shots displayed in home page
Screen Shot 2022-09-26 at 12 14 34 PM

Screen Shot 2022-09-26 at 12 14 05 PM

@nreese
Copy link
Contributor Author

nreese commented Sep 28, 2022

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Sep 28, 2022

@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review September 28, 2022 19:47
@nreese nreese requested a review from a team September 28, 2022 19:47
@nreese nreese requested review from a team as code owners September 28, 2022 19:47
@nreese nreese added v8.6.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Sep 28, 2022
lukeelmers
lukeelmers approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core test update lgtm

@nreese
Copy link
Contributor Author

nreese commented Sep 30, 2022

@elasticmachine merge upstream

rshen91
rshen91 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM 👍🏻

Heenawter
Heenawter approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation functional test service addition LGTM 👍 Code only review

@nreese
Copy link
Contributor Author

nreese commented Oct 3, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan
tsullivan approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppServices changes LGTM.

Viewed the code changes.

@nreese nreese merged commit 999bc84 into elastic:main Oct 4, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@nreese @kibanamachine @WafaaNasr
[Sample data] replace legacy control visualizations with dashboard co…
841ce5f 
…ntrols (elastic#141824)

* [Sample data] replace legacy control visualizations with dashboard controls

* i18n wrappings for title and description

* update screen shots

* fix functional tests

* update functional test expects

* more functional test expect updates

Co-authored-by: Kibana Machine <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@nreese @kibanamachine @WafaaNasr
[Sample data] replace legacy control visualizations with dashboard co…
f47638b 
…ntrols (elastic#141824)

* [Sample data] replace legacy control visualizations with dashboard controls

* i18n wrappings for title and description

* update screen shots

* fix functional tests

* update functional test expects

* more functional test expect updates

Co-authored-by: Kibana Machine <[email protected]>
@KOTungseth KOTungseth mentioned this pull request Nov 16, 2022
Merged
KOTungseth added a commit that referenced this pull request Nov 28, 2022
@KOTungseth @gchaps
[DOCS] Adds the 8.6 Presentation docs (#145474)
9a26af6 
## Summary

Adds the docs for the following:

- #141824
Doc preview:
https://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/get-started.html

- #142780
Doc preview:
https://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html

- #143762
Doc preview:
https://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html

Co-authored-by: gchaps <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 28, 2022
@KOTungseth
[DOCS] Adds the 8.6 Presentation docs (elastic#145474)
a3cfcbd 
## Summary

Adds the docs for the following:

- elastic#141824
Doc preview:
https://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/get-started.html

- elastic#142780
Doc preview:
https://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html

- elastic#143762
Doc preview:
https://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html

Co-authored-by: gchaps <[email protected]>
(cherry picked from commit 9a26af6)
kibanamachine added a commit that referenced this pull request Nov 28, 2022
@kibanamachine @KOTungseth
[8.6] [DOCS] Adds the 8.6 Presentation docs (#145474) (#146430)
dad6bff 
# Backport

This will backport the following commits from `main` to `8.6`:
- [[DOCS] Adds the 8.6 Presentation docs
(#145474)](#145474)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kaarina
Tungseth","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-28T16:20:38Z","message":"[DOCS]
Adds the 8.6 Presentation docs (#145474)\n\n## Summary\r\n\r\nAdds the
docs for the following:\r\n\r\n- #141824\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/get-started.html\r\n\r\n-
#142780\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\n-
#143762\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\nCo-authored-by:
gchaps
<[email protected]>","sha":"9a26af6facafa9519ac624901805a1a65c8abb09","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Presentation","release_note:skip","v8.6.0","v8.7.0"],"number":145474,"url":"https://github.com/elastic/kibana/pull/145474","mergeCommit":{"message":"[DOCS]
Adds the 8.6 Presentation docs (#145474)\n\n## Summary\r\n\r\nAdds the
docs for the following:\r\n\r\n- #141824\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/get-started.html\r\n\r\n-
#142780\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\n-
#143762\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\nCo-authored-by:
gchaps
<[email protected]>","sha":"9a26af6facafa9519ac624901805a1a65c8abb09"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145474","number":145474,"mergeCommit":{"message":"[DOCS]
Adds the 8.6 Presentation docs (#145474)\n\n## Summary\r\n\r\nAdds the
docs for the following:\r\n\r\n- #141824\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/get-started.html\r\n\r\n-
#142780\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\n-
#143762\r\nDoc
preview:\r\nhttps://kibana_145474.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html\r\n\r\nCo-authored-by:
gchaps
<[email protected]>","sha":"9a26af6facafa9519ac624901805a1a65c8abb09"}}]}]
BACKPORT-->

Co-authored-by: Kaarina Tungseth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

@Heenawter Heenawter Heenawter approved these changes

@rshen91 rshen91 rshen91 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nreese @elasticmachine @kibana-ci @tsullivan @lukeelmers @Heenawter @rshen91 @kibanamachine