Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] refactors update rule actions tests #142464

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Oct 3, 2022

Summary

according to proposal in above task:

  • removes step of updating immutable rule with mock data
  • makes assertions whether rule properties were not modified against fetched earlier immutable rule

Checklist

Sorry, something went wrong.

@vitaliidm vitaliidm self-assigned this Oct 3, 2022
@vitaliidm vitaliidm added backport refactoring release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.5.0 v8.6.0 labels Oct 3, 2022
@vitaliidm vitaliidm added technical debt Improvement of the software architecture and operational architecture backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport labels Oct 3, 2022
@vitaliidm vitaliidm marked this pull request as ready for review October 3, 2022 15:26
@vitaliidm vitaliidm requested a review from a team as a code owner October 3, 2022 15:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@vitaliidm vitaliidm requested review from a team and maximpn and removed request for a team October 3, 2022 15:27
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitaliidm vitaliidm merged commit 10884e6 into elastic:main Oct 4, 2022
@vitaliidm vitaliidm deleted the detections/update-actions branch October 4, 2022 09:39
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 4, 2022
…lastic#142464)

## Summary

- addresses elastic#138757

according to proposal in above task:
- removes step of updating immutable rule with mock data
- makes assertions whether rule properties were not modified against fetched earlier immutable rule

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

(cherry picked from commit 10884e6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 4, 2022
…142464) (#142567)

## Summary

- addresses #138757

according to proposal in above task:
- removes step of updating immutable rule with mock data
- makes assertions whether rule properties were not modified against fetched earlier immutable rule

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

(cherry picked from commit 10884e6)

Co-authored-by: Vitalii Dmyterko <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
…lastic#142464)

## Summary

- addresses elastic#138757

according to proposal in above task:
- removes step of updating immutable rule with mock data
- makes assertions whether rule properties were not modified against fetched earlier immutable rule


### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
…lastic#142464)

## Summary

- addresses elastic#138757

according to proposal in above task:
- removes step of updating immutable rule with mock data
- makes assertions whether rule properties were not modified against fetched earlier immutable rule


### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) refactoring release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture test-coverage issues & PRs for improving code test coverage v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants