-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detections] refactors update rule actions tests #142464
Conversation
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @vitaliidm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…lastic#142464) ## Summary - addresses elastic#138757 according to proposal in above task: - removes step of updating immutable rule with mock data - makes assertions whether rule properties were not modified against fetched earlier immutable rule ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 10884e6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…142464) (#142567) ## Summary - addresses #138757 according to proposal in above task: - removes step of updating immutable rule with mock data - makes assertions whether rule properties were not modified against fetched earlier immutable rule ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 10884e6) Co-authored-by: Vitalii Dmyterko <[email protected]>
…lastic#142464) ## Summary - addresses elastic#138757 according to proposal in above task: - removes step of updating immutable rule with mock data - makes assertions whether rule properties were not modified against fetched earlier immutable rule ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…lastic#142464) ## Summary - addresses elastic#138757 according to proposal in above task: - removes step of updating immutable rule with mock data - makes assertions whether rule properties were not modified against fetched earlier immutable rule ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Summary
according to proposal in above task:
Checklist